Port rustc_strict_coherence to the new attribute parser
#152171
Merged
+29
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_hir/src/attrs |
rustbot
added
A-attributes
9 tasks
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
port-rustc-strict-coherence
branch
from
717f1f5 to
1d1c0ae
Compare
Contributor
|
r=me after #152170 merged, or make this PR not based on that one |
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
jdonszelmann
force-pushed
the
port-rustc-strict-coherence
branch
from
1d1c0ae to
e51f69e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
port-rustc-strict-coherence
branch
from
e51f69e to
b532705
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
port-rustc-strict-coherence
branch
from
b532705 to
42a5658
Compare
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
port-rustc-strict-coherence
branch
from
42a5658 to
2dda303
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=jonathanbrouwer |
Contributor
rust-bors
bot
added
the
S-waiting-on-bors
rust-bors
bot
removed
the
S-waiting-on-author
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 9, 2026
Rollup of 4 pull requests Successful merges: - #150823 (Implement MVP for opaque generic const arguments) - #152071 (Implement stdio FD constants) - #152171 (Port `rustc_strict_coherence` to the new attribute parser) - #152291 (Port `rustc_insignificant_dtor`) Failed merges: - #152180 (Port `rustc_reservation_impl` to the new attribute parser)
rust-timer
added a commit
that referenced
this pull request
Feb 9, 2026
Rollup merge of #152171 - jdonszelmann:port-rustc-strict-coherence, r=jonathanbrouwer Port `rustc_strict_coherence` to the new attribute parser r? @JonathanBrouwer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @JonathanBrouwer