Conversation
|
I suspect this will run into issues with some badly written tests, will do a CI run once it starts working again. |
|
@bors try jobs=apple |
This comment has been minimized.
This comment has been minimized.
Update to Xcode 26.2 try-job: *apple*
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 16cbdc0 failed: CI. Failed job:
|
|
I think we might need to use the Xcode-provided Clang on @bors try jobs=apple |
This comment has been minimized.
This comment has been minimized.
Update to Xcode 26.2 try-job: *apple*
|
💥 Test timed out after |
|
Hmm. I'd expect the first build with this to take longer because it busts basically the entire build cache, but I wouldn't have expected it to take that long. Maybe it's due to the recent CI outage that GitHub Actions had, which might make jobs slower while they're catching up? I'll wait a few more hours to a day, and then retry the build. |
This comment has been minimized.
This comment has been minimized.
|
@bors try jobs=apple |
This comment has been minimized.
This comment has been minimized.
Update to Xcode 26.2 try-job: *apple*
This comment has been minimized.
This comment has been minimized.
…shepmaster Always use Xcode-provided Clang in macOS CI Most of our macOS CI runners use the Xcode-provided Clang. `dist-apple-various` still downloads Clang from LLVM's prebuilt sources, which is a bit problematic, because we're still using the Xcode-provided _headers_. As a concrete example, using Xcode's Clang is required by rust-lang#152013, as otherwise updating to Xcode 26 headers fails with an obscure `fatal error: 'net/route.h' file not found`, see [this build log](rust-lang#152013 (comment)). I suspect this is because building the new headers isn't officially supported with the older LLVM/Clang 15. This PR removes that functionality, so that we instead always build with the Xcode-provided Clang. This is effectively the same as setting `USE_XCODE_CLANG=1` on `dist-apple-various` as well, but I thought I'd clean things up while I'm at it. I didn't find the reason why we did this in first place, maybe because the Xcode Clang at the time was too out of date to build LLVM? It doesn't seem to be a problem anymore though. r? t-infra
…shepmaster Always use Xcode-provided Clang in macOS CI Most of our macOS CI runners use the Xcode-provided Clang. `dist-apple-various` still downloads Clang from LLVM's prebuilt sources, which is a bit problematic, because we're still using the Xcode-provided _headers_. As a concrete example, using Xcode's Clang is required by rust-lang#152013, as otherwise updating to Xcode 26 headers fails with an obscure `fatal error: 'net/route.h' file not found`, see [this build log](rust-lang#152013 (comment)). I suspect this is because building the new headers isn't officially supported with the older LLVM/Clang 15. This PR removes that functionality, so that we instead always build with the Xcode-provided Clang. This is effectively the same as setting `USE_XCODE_CLANG=1` on `dist-apple-various` as well, but I thought I'd clean things up while I'm at it. I didn't find the reason why we did this in first place, maybe because the Xcode Clang at the time was too out of date to build LLVM? It doesn't seem to be a problem anymore though. r? t-infra
…shepmaster Always use Xcode-provided Clang in macOS CI Most of our macOS CI runners use the Xcode-provided Clang. `dist-apple-various` still downloads Clang from LLVM's prebuilt sources, which is a bit problematic, because we're still using the Xcode-provided _headers_. As a concrete example, using Xcode's Clang is required by rust-lang#152013, as otherwise updating to Xcode 26 headers fails with an obscure `fatal error: 'net/route.h' file not found`, see [this build log](rust-lang#152013 (comment)). I suspect this is because building the new headers isn't officially supported with the older LLVM/Clang 15. This PR removes that functionality, so that we instead always build with the Xcode-provided Clang. This is effectively the same as setting `USE_XCODE_CLANG=1` on `dist-apple-various` as well, but I thought I'd clean things up while I'm at it. I didn't find the reason why we did this in first place, maybe because the Xcode Clang at the time was too out of date to build LLVM? It doesn't seem to be a problem anymore though. r? t-infra
Rollup merge of #152192 - madsmtm:remove-use-xcode-clang, r=shepmaster Always use Xcode-provided Clang in macOS CI Most of our macOS CI runners use the Xcode-provided Clang. `dist-apple-various` still downloads Clang from LLVM's prebuilt sources, which is a bit problematic, because we're still using the Xcode-provided _headers_. As a concrete example, using Xcode's Clang is required by #152013, as otherwise updating to Xcode 26 headers fails with an obscure `fatal error: 'net/route.h' file not found`, see [this build log](#152013 (comment)). I suspect this is because building the new headers isn't officially supported with the older LLVM/Clang 15. This PR removes that functionality, so that we instead always build with the Xcode-provided Clang. This is effectively the same as setting `USE_XCODE_CLANG=1` on `dist-apple-various` as well, but I thought I'd clean things up while I'm at it. I didn't find the reason why we did this in first place, maybe because the Xcode Clang at the time was too out of date to build LLVM? It doesn't seem to be a problem anymore though. r? t-infra
This comment has been minimized.
This comment has been minimized.
This also updates the macOS runners to run on macOS 15 (the macOS 14 runners only have up to Xcode 16.2 available).
This comment has been minimized.
This comment has been minimized.
Update to Xcode 26.2 try-job: *apple*
|
💥 Test timed out after |
|
Seems like the second time might have access to more cached data: |
This comment has been minimized.
This comment has been minimized.
Update to Xcode 26.2 try-job: *apple*
|
💥 Test timed out after |
This comment has been minimized.
This comment has been minimized.
Update to Xcode 26.2 try-job: *apple*
|
Seemed to complete within reasonable timeframes, so was probably just some caching weirdness. @rustbot ready |
|
This is probably compile-time performance-sensitive, since LLVM will be built with a newer Clang version (as I understand it, LLVM is only built once, unlike Should still be safe to rollup though, as macOS performance isn't tested by |
Update our CI to run with Xcode 26.
This means that:
rustcandlibstd*.dylib) will have their SDK version raised (before macOS 14.5, now 26.2).The last two points can be observed with:
This shouldn't have much of an effect, but things like
dyldis known to inspect the SDK version, so it might expose some latent bugs (I really don't expect it to though).This also updates the macOS runners to run on macOS 15 (the macOS 14 runners only have up to Xcode 16.2 available). That is desirable anyhow, as the macOS 14 runners will be deprecated in July. This is probably also required for #147192.
r? shepmaster