Implement RFC 3678: Final trait methods#151783
Implement RFC 3678: Final trait methods#151783mu001999 wants to merge 7 commits intorust-lang:mainfrom
Conversation
|
Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs cc @ZuseZ4 Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
|
Could you mark errs as a coauthor in all 6 commits, I think that's only fair. Thanks! :) Namely: |
fe8e71f to
f0df197
Compare
|
@fmease Done. Thanks for the reminder! :) |
Does this implement the requirement that final methods don't prevent a trait from being dyn-compatible? |
This comment was marked as outdated.
This comment was marked as outdated.
ca5e458 to
a0707ab
Compare
a0707ab to
5c978e5
Compare
Implemented now :). Also, updated the PR description. |
This comment has been minimized.
This comment has been minimized.
5c978e5 to
05c342d
Compare
This comment has been minimized.
This comment has been minimized.
05c342d to
a630df6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a630df6 to
3a8a6a5
Compare
This comment has been minimized.
This comment has been minimized.
3a8a6a5 to
e9be248
Compare
This comment has been minimized.
This comment has been minimized.
|
Spurious failure |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Michael Goulet <[email protected]>
Co-authored-by: Michael Goulet <[email protected]>
Co-authored-by: Michael Goulet <[email protected]>
Co-authored-by: Michael Goulet <[email protected]>
Co-authored-by: Michael Goulet <[email protected]>
Co-authored-by: Michael Goulet <[email protected]>
e9be248 to
d8cf1a0
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Tracking: #131179
This PR is based on #130802, with some minor changes and conflict resolution.
Futhermore, this PR excludes final methods from the vtable of a dyn Trait.
And some excerpt from the original PR description:
cc @joshtriplett