compiletest: Parse aux proc-macro directive into struct
#151670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
To minimize the diff when adding features the aux `proc-macro` directive.
Enselic
force-pushed
the
proc-macro-struct
branch
from
be7b3f2 to
30e41de
Compare
Enselic
changed the title
proc-pacro directive into structproc-macro directive into struct
Zalathar
reviewed
Jan 26, 2026
| } | ||
|
|
||
| /// The value of a `proc-macro` directive. | ||
| #[derive(Clone, Debug, Default)] |
Member
There was a problem hiding this comment.
Remark: These structs shouldn't actually need to be Default, but I'm fine with merging this as-is (since it matches the others) and then fixing all of them in a separate follow-up PR.
Member
|
Thanks for splitting these up; it makes reviewing each part much nicer. @bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 26, 2026
compiletest: Parse aux `proc-macro` directive into struct This PR does not introduce any changes. It is pure refactoring to make PR rust-lang#151258 smaller so it is easier to see what that PR is about, as discussed [here](rust-lang#151258 (comment)). r? @Zalathar
rust-timer
added a commit
that referenced
this pull request
Jan 26, 2026
Rollup merge of #151670 - Enselic:proc-macro-struct, r=Zalathar compiletest: Parse aux `proc-macro` directive into struct This PR does not introduce any changes. It is pure refactoring to make PR #151258 smaller so it is easier to see what that PR is about, as discussed [here](#151258 (comment)). r? @Zalathar
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jan 29, 2026
Rollup of 2 pull requests Successful merges: - rust-lang/rust#151612 (Update documentation for `cold_path`, `likely`, and `unlikely`) - rust-lang/rust#151670 (compiletest: Parse aux `proc-macro` directive into struct)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 2, 2026
…thar compiletest: Support `--extern` modifiers with `proc-macro` directive So that the `src/tools/compiletest/src/directives/auxiliary/tests.rs` test does not have to (ab)use the `aux-crate` directive for this purpose. This is very edge-casey so I don't think we should document this in rustc-dev-guide. Mentioning it will confuse more than it helps. If someone needs to do this they will look at the code and easily find the functionality. This is a bit hacky since `--extern priv:pm.rs` is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic approach. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if wanted. r? @Zalathar --- Follow-up to: - rust-lang#151353 - rust-lang#151670 ### Unblocks: - rust-lang#151691, because without this fix that test fails (see rust-lang#151691 (comment))
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 2, 2026
…thar compiletest: Support `--extern` modifiers with `proc-macro` directive So that the `src/tools/compiletest/src/directives/auxiliary/tests.rs` test does not have to (ab)use the `aux-crate` directive for this purpose. This is very edge-casey so I don't think we should document this in rustc-dev-guide. Mentioning it will confuse more than it helps. If someone needs to do this they will look at the code and easily find the functionality. This is a bit hacky since `--extern priv:pm.rs` is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic approach. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if wanted. r? @Zalathar --- Follow-up to: - rust-lang#151353 - rust-lang#151670 ### Unblocks: - rust-lang#151691, because without this fix that test fails (see rust-lang#151691 (comment))
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 2, 2026
…thar compiletest: Support `--extern` modifiers with `proc-macro` directive So that the `src/tools/compiletest/src/directives/auxiliary/tests.rs` test does not have to (ab)use the `aux-crate` directive for this purpose. This is very edge-casey so I don't think we should document this in rustc-dev-guide. Mentioning it will confuse more than it helps. If someone needs to do this they will look at the code and easily find the functionality. This is a bit hacky since `--extern priv:pm.rs` is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic approach. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if wanted. r? @Zalathar --- Follow-up to: - rust-lang#151353 - rust-lang#151670 ### Unblocks: - rust-lang#151691, because without this fix that test fails (see rust-lang#151691 (comment))
rust-timer
added a commit
that referenced
this pull request
Feb 3, 2026
Rollup merge of #151695 - Enselic:proc-macro-priv-v2, r=Zalathar compiletest: Support `--extern` modifiers with `proc-macro` directive So that the `src/tools/compiletest/src/directives/auxiliary/tests.rs` test does not have to (ab)use the `aux-crate` directive for this purpose. This is very edge-casey so I don't think we should document this in rustc-dev-guide. Mentioning it will confuse more than it helps. If someone needs to do this they will look at the code and easily find the functionality. This is a bit hacky since `--extern priv:pm.rs` is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic approach. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if wanted. r? @Zalathar --- Follow-up to: - #151353 - #151670 ### Unblocks: - #151691, because without this fix that test fails (see #151691 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not introduce any changes. It is pure refactoring to make PR #151258 smaller so it is easier to see what that PR is about, as discussed here.
r? @Zalathar