Skip to content

Port symbol mangler attrs#150949

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Bryntet:port_symbol_mangler_attrs
Feb 7, 2026
Merged

Port symbol mangler attrs#150949
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Bryntet:port_symbol_mangler_attrs

Conversation

@Bryntet
Copy link
Contributor

@Bryntet Bryntet commented Jan 11, 2026

Tracking issue: #131229

@JonathanBrouwer could you run perf on this?

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 11, 2026
@JonathanBrouwer
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Jan 11, 2026
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

☀️ Try build successful (CI)
Build commit: 3162956 (3162956ac6c60e4ef7d9ae98b1319ef2d1e08ec6, parent: 9bc8b40bc314b74e1d5e5ab21a0df39c55a34806)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3162956): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.4%, -0.0%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.6% [0.6%, 0.6%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.8% [-3.5%, -2.0%] 2
All ❌✅ (primary) - - 0

Cycles

Results (secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-10.2% [-10.2%, -10.2%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.122s -> 472.718s (-0.09%)
Artifact size: 391.33 MiB -> 391.30 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

☔ The latest upstream changes (presumably #150957) made this pull request unmergeable. Please resolve the merge conflicts.

@Bryntet Bryntet force-pushed the port_symbol_mangler_attrs branch 2 times, most recently from aafb475 to 0e0bbee Compare January 12, 2026 17:21
@jdonszelmann
Copy link
Contributor

@Bryntet any chance we can merge this one soon? Ran into wanting it converted in another PR :3

@Bryntet Bryntet marked this pull request as ready for review February 5, 2026 12:44
@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 5, 2026
@Bryntet Bryntet force-pushed the port_symbol_mangler_attrs branch from 0e0bbee to 62fd7ad Compare February 5, 2026 12:44
@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2026

r? @madsmtm

rustbot has assigned @madsmtm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

@Bryntet
Copy link
Contributor Author

Bryntet commented Feb 5, 2026

r? @jdonszelmann

thanks for reminding me about this PR, had forgotten about it

@rustbot rustbot assigned jdonszelmann and unassigned madsmtm Feb 5, 2026
@Bryntet Bryntet force-pushed the port_symbol_mangler_attrs branch from 62fd7ad to ca6ebc5 Compare February 5, 2026 12:49
@rustbot

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 5, 2026
@rust-log-analyzer

This comment has been minimized.

@Bryntet Bryntet force-pushed the port_symbol_mangler_attrs branch from ca6ebc5 to ef7013f Compare February 5, 2026 14:02
@rust-log-analyzer

This comment has been minimized.

@Bryntet Bryntet force-pushed the port_symbol_mangler_attrs branch from ef7013f to 1304f22 Compare February 5, 2026 22:40
@rust-log-analyzer

This comment has been minimized.

@Bryntet
Copy link
Contributor Author

Bryntet commented Feb 5, 2026

@rustbot ready

CI seems to fail due to rustdoc-gui, on 4 tests which (at least on my machine) fail on latest main as well..

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 5, 2026
@rust-bors

This comment was marked as off-topic.

@JonathanBrouwer
Copy link
Contributor

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2026
@rust-bors

This comment has been minimized.

@Bryntet Bryntet force-pushed the port_symbol_mangler_attrs branch from 1304f22 to 10f0c2d Compare February 7, 2026 00:43
@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Bryntet
Copy link
Contributor Author

Bryntet commented Feb 7, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 7, 2026
@JonathanBrouwer
Copy link
Contributor

@bors r=jdonszelmann,JonathanBrouwer rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 7, 2026

📌 Commit 10f0c2d has been approved by jdonszelmann,JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 7, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #146900 (Add avr_target_feature)
 - #150949 (Port symbol mangler attrs)
 - #152252 (Convert diagnostic style checks)
 - #152265 (Use `.map.collect` to aggregate in `.to_ty` of tuples)
@rust-bors rust-bors bot merged commit defc1d7 into rust-lang:main Feb 7, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 7, 2026
rust-timer added a commit that referenced this pull request Feb 7, 2026
Rollup merge of #150949 - Bryntet:port_symbol_mangler_attrs, r=jdonszelmann,JonathanBrouwer

Port symbol mangler attrs

Tracking issue: #131229

@JonathanBrouwer could you run perf on this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants