Stabilize `atomic_try_update`and deprecate `fetch_update` starting 1.99.0 by GrigorenkoPV · Pull Request #148590 · rust-lang/rust

GrigorenkoPV · 2025-11-06T17:17:59Z

Tracking issue: #135894
FCP completed: #135894 (comment)

1.96.0 was chosen because I don't think the remaining month until 1.93.0 becomes beta is enough for the FCP to finish and this to get merged, so 1.94.0 + a couple of versions of leeway: #135894 (comment)

1.99 suggested in #148590 (comment)

Closes #135894

hanna-kruppe · 2025-11-06T18:36:56Z

I would suggest splitting out the lint change into a separate PR. It would be useful even before stabilization, I don't think it requires its own FCP, and it'll make the API stabilization itself a bit easier to review. That's especially important since the simultaneous deprecation makes it a big and tricky diff by stabilization standards!

GrigorenkoPV · 2025-11-06T18:55:38Z

Good idea!

Done: #148601

…ng, r=Kivooeo `invalid_atomic_ordering`: also lint `update` & `try_update` Split from rust-lang#148590 Tracking issue for `update` and `try_update`: rust-lang#135894

Rollup merge of #148601 - GrigorenkoPV:invalid_atomic_ordering, r=Kivooeo `invalid_atomic_ordering`: also lint `update` & `try_update` Split from #148590 Tracking issue for `update` and `try_update`: #135894

…ooeo `invalid_atomic_ordering`: also lint `update` & `try_update` Split from rust-lang/rust#148590 Tracking issue for `update` and `try_update`: rust-lang/rust#135894

…ng, r=Kivooeo `invalid_atomic_ordering`: also lint `update` & `try_update` Split from rust-lang#148590 Tracking issue for `update` and `try_update`: rust-lang#135894

…ooeo `invalid_atomic_ordering`: also lint `update` & `try_update` Split from rust-lang/rust#148590 Tracking issue for `update` and `try_update`: rust-lang/rust#135894

bors · 2025-11-23T00:19:32Z

☔ The latest upstream changes (presumably #149222) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2025-12-24T23:22:28Z

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

GrigorenkoPV · 2025-12-24T23:24:34Z

@rustbot label -S-waiting-on-FCP

RIP

GrigorenkoPV · 2026-01-24T18:20:06Z

@rustbot reroll

Or what was that new command named

jhpratt · 2026-01-25T04:22:31Z

library/core/src/sync/atomic.rs

    #[cfg_attr(miri, track_caller)] // even without panics, this helps for Miri backtraces
    #[rustc_should_not_be_called_on_const_items]
+    #[deprecated(
+        since = "1.96.0",


ping @Amanieu from #135894 (comment)

Point of clarification. Is it intended to deprecate this immediately with stabilization, have this set to a version further down the line, or simply TBD like the u8 module?

(also, does CURRENT_RUSTC_VERSION work here?)

No, it's fine to delay the deprecation by a few versions. This will give people time to transition to the new API without warnings.

@GrigorenkoPV Let's change it to 1.99 then. That'll be an 18 week period between stabilization and deprecation.

and deprecate fetch_update starting 1.99.0

rustbot · 2026-01-27T18:15:44Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jhpratt · 2026-02-07T04:20:42Z

@bors r+

rust-bors · 2026-02-07T04:20:45Z

📌 Commit 3a48b9f has been approved by jhpratt

It is now in the queue for this repository.

…jhpratt Stabilize `atomic_try_update`and deprecate `fetch_update` starting 1.99.0 Tracking issue: rust-lang#135894 FCP completed: rust-lang#135894 (comment) ~1.96.0 was chosen because I don't think the remaining month until 1.93.0 becomes beta is enough for the FCP to finish and this to get merged, so 1.94.0 + a couple of versions of leeway: rust-lang#135894 (comment) 1.99 suggested in rust-lang#148590 (comment) Closes rust-lang#135894

Rollup of 4 pull requests Successful merges: - #148590 (Stabilize `atomic_try_update`and deprecate `fetch_update` starting 1.99.0) - #150522 (Stabilize new inclusive range type and iterator type) - #151576 (Stabilize `core::hint::cold_path`) - #152199 (Move `rustc_query_system::cache`.)

…jhpratt Stabilize `atomic_try_update`and deprecate `fetch_update` starting 1.99.0 Tracking issue: rust-lang#135894 FCP completed: rust-lang#135894 (comment) ~1.96.0 was chosen because I don't think the remaining month until 1.93.0 becomes beta is enough for the FCP to finish and this to get merged, so 1.94.0 + a couple of versions of leeway: rust-lang#135894 (comment) 1.99 suggested in rust-lang#148590 (comment) Closes rust-lang#135894

rust-bors · 2026-02-07T12:06:44Z

⌛ Testing commit 3a48b9f with merge 83d71ef...

Workflow: https://github.com/rust-lang/rust/actions/runs/21779822668

Stabilize `atomic_try_update`and deprecate `fetch_update` starting 1.99.0 Tracking issue: #135894 FCP completed: #135894 (comment) ~1.96.0 was chosen because I don't think the remaining month until 1.93.0 becomes beta is enough for the FCP to finish and this to get merged, so 1.94.0 + a couple of versions of leeway: #135894 (comment) 1.99 suggested in #148590 (comment) Closes #135894

JonathanBrouwer · 2026-02-07T12:06:58Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-02-07T12:07:01Z

Auto build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/21779822668

The next pull request likely to be tested is #152282.

…uwer Rollup of 8 pull requests Successful merges: - #148590 (Stabilize `atomic_try_update`and deprecate `fetch_update` starting 1.99.0) - #150522 (Stabilize new inclusive range type and iterator type) - #152235 (Convert to inline diagnostics in `rustc_parse`) - #152267 (feat: Implement `int_from_ascii` for `NonZero<T>`) - #151576 (Stabilize `core::hint::cold_path`) - #151933 (Linker-plugin-based LTO: give an explanation how to use linker-plugin-lto with full LTO) - #152010 (Ignore all debuginfo tests for LLDB that we do not run in CI) - #152199 (Move `rustc_query_system::cache`.)

Rollup merge of #148590 - GrigorenkoPV:atomic_try_update, r=jhpratt Stabilize `atomic_try_update`and deprecate `fetch_update` starting 1.99.0 Tracking issue: #135894 FCP completed: #135894 (comment) ~1.96.0 was chosen because I don't think the remaining month until 1.93.0 becomes beta is enough for the FCP to finish and this to get merged, so 1.94.0 + a couple of versions of leeway: #135894 (comment) 1.99 suggested in #148590 (comment) Closes #135894

GrigorenkoPV mentioned this pull request Nov 6, 2025

Tracking Issue for atomic_try_update #135894

Closed

5 tasks

GrigorenkoPV mentioned this pull request Nov 6, 2025

invalid_atomic_ordering: also lint update & try_update #148601

Merged

GrigorenkoPV force-pushed the atomic_try_update branch from 02e586c to 67b2e92 Compare November 6, 2025 18:55

GrigorenkoPV force-pushed the atomic_try_update branch from 67b2e92 to 7ffe34e Compare November 9, 2025 12:40

GrigorenkoPV force-pushed the atomic_try_update branch from 7ffe34e to 9a0eb78 Compare November 23, 2025 11:41

This comment has been minimized.

Sign in to view

GrigorenkoPV force-pushed the atomic_try_update branch from 9a0eb78 to 0733988 Compare November 23, 2025 13:49

GrigorenkoPV marked this pull request as ready for review December 24, 2025 23:22

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 24, 2025

rustbot assigned scottmcm Dec 24, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 24, 2025

This comment has been minimized.

Sign in to view

GrigorenkoPV force-pushed the atomic_try_update branch from 0733988 to 65e453c Compare December 24, 2025 23:27

rustbot assigned jhpratt and unassigned Amanieu Jan 24, 2026

jhpratt removed the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Jan 25, 2026

jhpratt reviewed Jan 25, 2026

View reviewed changes

Stabilize atomic_try_update

3a48b9f

and deprecate fetch_update starting 1.99.0

GrigorenkoPV force-pushed the atomic_try_update branch from 65e453c to 3a48b9f Compare January 27, 2026 18:15

GrigorenkoPV changed the title ~~Stabilize atomic_try_updateand deprecate fetch_update starting 1.96.0~~ Stabilize atomic_try_updateand deprecate fetch_update starting 1.99.0 Jan 27, 2026

GrigorenkoPV requested review from Amanieu and jhpratt February 5, 2026 21:49

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2026

jhpratt mentioned this pull request Feb 7, 2026

Rollup of 4 pull requests #152266

Closed

This was referenced Feb 7, 2026

Rollup of 9 pull requests #152279

Closed

Rollup of 8 pull requests #152282

Merged

rust-bors bot merged commit 6fe0999 into rust-lang:main Feb 7, 2026
11 of 12 checks passed

rustbot added this to the 1.95.0 milestone Feb 7, 2026

GrigorenkoPV deleted the atomic_try_update branch February 7, 2026 15:42

Uh oh!

Conversation

GrigorenkoPV commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hanna-kruppe commented Nov 6, 2025

Uh oh!

GrigorenkoPV commented Nov 6, 2025

Uh oh!

bors commented Nov 23, 2025

Uh oh!

This comment has been minimized.

rustbot commented Dec 24, 2025

Uh oh!

This comment has been minimized.

GrigorenkoPV commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GrigorenkoPV commented Jan 24, 2026

Uh oh!

jhpratt Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Amanieu Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

jhpratt Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jan 27, 2026

Uh oh!

jhpratt commented Feb 7, 2026

Uh oh!

rust-bors bot commented Feb 7, 2026

Uh oh!

rust-bors bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Feb 7, 2026

Uh oh!

rust-bors bot commented Feb 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

GrigorenkoPV commented Nov 6, 2025 •

edited

Loading

GrigorenkoPV commented Dec 24, 2025 •

edited

Loading

rust-bors bot commented Feb 7, 2026 •

edited

Loading