-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Move more code out of unicode-table-generator into core
#148365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If you want to modify |
|
rustbot has assigned @Mark-Simulacrum. Use |
b3de674 to
8858dcd
Compare
This comment has been minimized.
This comment has been minimized.
8858dcd to
54790a3
Compare
This comment has been minimized.
This comment has been minimized.
54790a3 to
4216557
Compare
This comment has been minimized.
This comment has been minimized.
4216557 to
7a40275
Compare
This comment has been minimized.
This comment has been minimized.
7a40275 to
687d9a1
Compare
|
Closing since it got reverted |
|
☔ The latest upstream changes (presumably #148436) made this pull request unmergeable. Please resolve the merge conflicts. |
You don't need to, the original PR will probably get relanded. |
|
Yeah, but I can propose the change there instead of separating it |
Extension to #147622 which further reduces the size of the generated code, moving more of it into libcore directly.
This way, the verification code and the unsafe methods are right next to each other can be more easily understood.
Doesn't actually affect the compiled data, just moves around the code.