Add a timeout to the remote-test-client connection
#147952
Open
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
rustbot has assigned @Mark-Simulacrum. Use |
jyn514
reviewed
Oct 22, 2025
pvdrz
force-pushed
the
pvdrz/remote-test-client-timeout
branch
from
1d1f5fd to
799df1c
Compare
jyn514
approved these changes
Oct 22, 2025
Enselic
requested changes
Oct 25, 2025
| total_dur += dur; | ||
| } | ||
|
|
||
| panic!("Test device at {device_address} timed out"); |
There was a problem hiding this comment.
It would be comforting with a test for this. I'm thinking a test where we make the binary connect to non-existing address and use a small timeout and assert on that it panics.
This comment has been minimized.
This comment has been minimized.
Enselic
requested changes
Oct 29, 2025
|
I'll assign myself to this one for now. r? Enselic |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Enselic
requested changes
Oct 30, 2025
rustbot
added
S-waiting-on-author
pvdrz
force-pushed
the
pvdrz/remote-test-client-timeout
branch
from
b79af79 to
7a6c157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
remote-test-clientdoesn't have a timeout when connecting to theremote-test-server. This means that running tests using it can hang indefinitely which causes issues when running tests on CI, for example.This PR now sets a default timeout of 5 minutes, meaning that if, for example,
TEST_DEVICE_ADDR=<IP:PORT> ./x test --target riscv64gc-unknown-linux-gnu tests/uiis run and theremote-test-serveris not reachable by the client, the client will panic after the timeout is reached.Additionally, the
TEST_DEVICE_CONNECT_TIMEOUTenv variable can be used to set up the timeout to any value (in seconds).