Skip to content

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Oct 20, 2025

Fixes the example from this comment - #147823 (comment).
Fixes #148143.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@fmease fmease assigned fmease and unassigned SparrowLii Oct 26, 2025
@fmease
Copy link
Member

fmease commented Oct 26, 2025

Thanks, that makes sense! @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 26, 2025

📌 Commit 078fe7c has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2025
@bors
Copy link
Collaborator

bors commented Oct 26, 2025

⌛ Testing commit 078fe7c with merge b1b464d...

@bors
Copy link
Collaborator

bors commented Oct 27, 2025

☀️ Test successful - checks-actions
Approved by: fmease
Pushing b1b464d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 27, 2025
@bors bors merged commit b1b464d into rust-lang:master Oct 27, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Oct 27, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f37aa99 (parent) -> b1b464d (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b1b464d6f61ec8c4e609c1328106378c066a9729 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 5875.0s -> 6842.9s (16.5%)
  2. i686-gnu-nopt-1: 8196.2s -> 6862.5s (-16.3%)
  3. pr-check-1: 1736.9s -> 1482.8s (-14.6%)
  4. x86_64-gnu-gcc: 3566.8s -> 3077.2s (-13.7%)
  5. aarch64-gnu-llvm-20-1: 3675.0s -> 3207.8s (-12.7%)
  6. aarch64-msvc-1: 6281.3s -> 7020.1s (11.8%)
  7. aarch64-gnu-llvm-20-2: 2430.0s -> 2168.3s (-10.8%)
  8. dist-aarch64-msvc: 5859.2s -> 5289.5s (-9.7%)
  9. arm-android: 6404.1s -> 5801.9s (-9.4%)
  10. dist-various-1: 3896.0s -> 4241.4s (8.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b1b464d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.2%, secondary -4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.2% [-1.2%, -1.2%] 1
Improvements ✅
(secondary)
-4.1% [-4.1%, -4.1%] 1
All ❌✅ (primary) -1.2% [-1.2%, -1.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.876s -> 474.573s (0.15%)
Artifact size: 390.50 MiB -> 390.41 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression with unused_imports on macro used in documentation

6 participants