hir_analysis: add missing sizedness bounds #142712

davidtwco · 2025-06-19T09:17:29Z

Depends on #144064

Default sizedness bounds were not being added to explicit_super_predicates_of and explicit_implied_predicates_of which meant that a trait bound added to a associated type projection would be missing the implied predicate of the default sizedness supertrait of that trait.

An unexpected consequence of this change was that the check for multiple principals was now finding an additional MetaSized principal when eagerly expanding trait aliases - which is fixed by skipping MetaSized when elaborating trait aliases in lowering dyn TraitAlias.

rustbot · 2025-06-19T09:17:34Z

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-06-19T09:17:37Z

HIR ty lowering was modified

cc @fmease

davidtwco · 2025-06-19T09:41:26Z

Wasn't expecting that failure, looking into it.

davidtwco · 2025-06-19T10:01:32Z

A smaller example of one of the failing crates (which happens with a stage two build):

#![crate_type = "lib"]

use std::marker::PhantomData;

pub trait ZeroMapKV<'a> {
    type Container;
}

pub trait ZeroFrom<'zf, C: ?Sized> {}

pub struct ZeroMap<'a, K: ZeroMapKV<'a>>(PhantomData<&'a K>);

impl<'zf, 's, K> ZeroFrom<'zf, ZeroMap<'s, K>> for ZeroMap<'zf, K>
where
    K: for<'b> ZeroMapKV<'b>,
    <K as ZeroMapKV<'zf>>::Container: ZeroFrom<'zf, <K as ZeroMapKV<'s>>::Container>,
{
}

error[E0308]: mismatched types
  --> f.rs:16:39
   |
16 |     <K as ZeroMapKV<'zf>>::Container: ZeroFrom<'zf, <K as ZeroMapKV<'s>>::Container>,
   |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lifetime mismatch
   |
   = note: expected trait `<<K as ZeroMapKV<'s>>::Container as MetaSized>`
              found trait `<<K as ZeroMapKV<'zf>>::Container as MetaSized>`
note: the lifetime `'zf` as defined here...
  --> f.rs:13:6
   |
13 | impl<'zf, 's, K> ZeroFrom<'zf, ZeroMap<'s, K>> for ZeroMap<'zf, K>
   |      ^^^
note: ...does not necessarily outlive the lifetime `'s` as defined here
  --> f.rs:13:11
   |
13 | impl<'zf, 's, K> ZeroFrom<'zf, ZeroMap<'s, K>> for ZeroMap<'zf, K>
   |           ^^

error[E0308]: mismatched types
  --> f.rs:16:39
   |
16 |     <K as ZeroMapKV<'zf>>::Container: ZeroFrom<'zf, <K as ZeroMapKV<'s>>::Container>,
   |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lifetime mismatch
   |
   = note: expected trait `<<K as ZeroMapKV<'s>>::Container as MetaSized>`
              found trait `<<K as ZeroMapKV<'zf>>::Container as MetaSized>`
note: the lifetime `'s` as defined here...
  --> f.rs:13:11
   |
13 | impl<'zf, 's, K> ZeroFrom<'zf, ZeroMap<'s, K>> for ZeroMap<'zf, K>
   |           ^^
note: ...does not necessarily outlive the lifetime `'zf` as defined here
  --> f.rs:13:6
   |
13 | impl<'zf, 's, K> ZeroFrom<'zf, ZeroMap<'s, K>> for ZeroMap<'zf, K>
   |      ^^^

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0308`.

petrochenkov · 2025-06-19T15:05:52Z

r? types

compiler-errors · 2025-06-19T16:43:05Z

I'd like to think about this...

Can you remind me, is trait Foo {} actually trait Foo: MetaSized {}?

tests/ui/sized-hierarchy/bound-on-assoc-type-projection.rs

davidtwco · 2025-06-23T20:38:24Z

I'd like to think about this...

Can you remind me, is trait Foo {} actually trait Foo: MetaSized {}?

Yes, it is

compiler-errors · 2025-06-27T14:15:40Z

I think this highlights a problematic interaction with trait aliases, and I'm tempted to say that trait aliases should have their behavior reworked to stop expanding into their bounds in dyn types. This would, for example, also fix dyn TraitAlias when trait TraitAlias = A + B, but that's a bigger change to advocate for I guess.

FOr now, I think it's inconsistent to not add MetaSized to trait aliases but add them to traits, and I think instead, to preserve/fix the tests, we should probably filter out MetaSized when we elaborate trait aliases when lowering dyn TraitAlias. This behavior should probably be tagged with a FIXME though.

davidtwco · 2025-06-27T16:10:29Z

I think this highlights a problematic interaction with trait aliases, and I'm tempted to say that trait aliases should have their behavior reworked to stop expanding into their bounds in dyn types. This would, for example, also fix dyn TraitAlias when trait TraitAlias = A + B, but that's a bigger change to advocate for I guess.

FOr now, I think it's inconsistent to not add MetaSized to trait aliases but add them to traits, and I think instead, to preserve/fix the tests, we should probably filter out MetaSized when we elaborate trait aliases when lowering dyn TraitAlias. This behavior should probably be tagged with a FIXME though.

Changed to this, thanks.

Still hitting the stage two failure, though I've added a UI test with my reproduction so that will fail first, not had much progress on working out what's going wrong with it.

davidtwco · 2025-07-03T14:19:48Z

See discussion on Zulip (#t-types > relaxing associated type bounds @ 💬) for background behind the last commit's changes.

davidtwco · 2025-07-07T10:13:22Z

@bors try

bors · 2025-07-07T10:14:34Z

⌛ Trying commit eac7da1 with merge 7df376b...

bors · 2025-07-07T12:30:04Z

☀️ Try build successful - checks-actions
Build commit: 7df376b (7df376b035b3d12ff0386ad8b45b76dbe020257b)

davidtwco · 2025-07-07T12:54:32Z

@craterbot check

compiler/rustc_hir_analysis/src/collect/predicates_of.rs

lcnr

final nits, then r=me

View changes since this review

tests/ui/sized-hierarchy/bound-on-assoc-type-projection.rs

Default sizedness bounds were not being added to `explicit_super_predicates_of` and `explicit_implied_predicates_of` which meant that a trait bound added to a associated type projection would be missing the implied predicate of the default sizedness supertrait of that trait. An unexpected consequence of this change was that the check for multiple principals was now finding an additional `MetaSized` principal when eagerly expanding trait aliases. Instead of special-casing trait aliases as different from traits and not adding a `MetaSized` supertrait to trait aliases, filter out `MetaSized` when lowering `dyn Trait`.

rustbot · 2025-10-24T14:28:44Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

davidtwco · 2025-10-24T18:21:57Z

@bors r=lcnr

bors · 2025-10-24T18:22:00Z

📌 Commit 82a4049 has been approved by lcnr

It is now in the queue for this repository.

bors · 2025-10-24T21:39:32Z

⌛ Testing commit 82a4049 with merge f435972...

bors · 2025-10-25T00:46:59Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing f435972 to master...

github-actions · 2025-10-25T00:49:53Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2aaa62b (parent) -> f435972 (this PR)

Test differences

Show 10 test diffs

Stage 1

[ui] tests/ui/sized-hierarchy/bound-on-assoc-type-projection.rs: [missing] -> pass (J1)
[ui] tests/ui/sized-hierarchy/elaboration-simple.rs: [missing] -> pass (J1)
[ui] tests/ui/sized-hierarchy/trait-alias-elaboration.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/sized-hierarchy/bound-on-assoc-type-projection.rs: [missing] -> pass (J0)
[ui] tests/ui/sized-hierarchy/elaboration-simple.rs: [missing] -> pass (J0)
[ui] tests/ui/sized-hierarchy/trait-alias-elaboration.rs: [missing] -> pass (J0)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f435972085b697a1ece8ee6a1ac76efff8d1df7b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

pr-check-1: 1906.0s -> 1450.5s (-23.9%)
x86_64-gnu-llvm-20-1: 3860.5s -> 3057.2s (-20.8%)
i686-gnu-nopt-1: 8086.4s -> 6853.6s (-15.2%)
i686-gnu-1: 8231.8s -> 7004.7s (-14.9%)
dist-apple-various: 3589.4s -> 3058.1s (-14.8%)
x86_64-gnu-llvm-20: 2808.3s -> 2409.8s (-14.2%)
dist-powerpc64le-linux-musl: 5759.8s -> 6551.3s (13.7%)
i686-gnu-2: 6243.6s -> 5461.7s (-12.5%)
x86_64-gnu-gcc: 3525.8s -> 3107.3s (-11.9%)
x86_64-rust-for-linux: 2903.0s -> 2575.0s (-11.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-25T02:05:52Z

Finished benchmarking commit (f435972): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.1%, 3.6%]	72
Regressions ❌ (secondary)	0.5%	[0.0%, 1.6%]	63
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.1%]	23
All ❌✅ (primary)	0.8%	[-0.1%, 3.6%]	73

Max RSS (memory usage)

Results (primary 0.4%, secondary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.7%, 2.6%]	2
Regressions ❌ (secondary)	1.0%	[0.7%, 1.3%]	2
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-3.6%	[-3.6%, -3.6%]	1
All ❌✅ (primary)	0.4%	[-2.3%, 2.6%]	3

Cycles

Results (primary 2.4%, secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.0%, 2.5%]	7
Regressions ❌ (secondary)	2.9%	[1.1%, 3.5%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.3%	[-5.3%, -5.3%]	1
All ❌✅ (primary)	2.4%	[2.0%, 2.5%]	7

Binary size

Results (primary 0.3%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.0%, 1.4%]	69
Regressions ❌ (secondary)	0.1%	[0.1%, 0.2%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	0.3%	[0.0%, 1.4%]	69

Bootstrap: 475.049s -> 474.979s (-0.01%)
Artifact size: 390.50 MiB -> 390.46 MiB (-0.01%)

panstromek · 2025-10-27T16:32:00Z

perf triage:

This seems to have caused quite a lot of regressions. @davidtwco Is this expected/justified? Can we do something to mitigate it or should we even revert?

davidtwco · 2025-11-03T16:17:08Z

These regressions aren't especially surprising given the change, but are required for correctness of this feature, there may be an optimisation we could add but we'd need to investigate.

rustbot assigned petrochenkov Jun 19, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 19, 2025

This comment has been minimized.

Sign in to view

rustbot added the T-types Relevant to the types team, which will review and decide on the PR/issue. label Jun 19, 2025

rustbot assigned jackh726 and unassigned petrochenkov Jun 19, 2025

compiler-errors assigned compiler-errors and unassigned jackh726 Jun 19, 2025

fmease reviewed Jun 19, 2025

View reviewed changes

tests/ui/sized-hierarchy/bound-on-assoc-type-projection.rs Show resolved Hide resolved

davidtwco force-pushed the sized-hierarchy-missing-default-bounds branch from 60d5044 to 7684842 Compare June 27, 2025 16:09

This comment has been minimized.

Sign in to view

davidtwco force-pushed the sized-hierarchy-missing-default-bounds branch from 7684842 to eac7da1 Compare July 3, 2025 14:18

davidtwco force-pushed the sized-hierarchy-missing-default-bounds branch from 3901931 to c4cf6ba Compare October 21, 2025 10:57

This comment has been minimized.

Sign in to view

davidtwco force-pushed the sized-hierarchy-missing-default-bounds branch from c4cf6ba to 4440b69 Compare October 21, 2025 11:00

lcnr reviewed Oct 23, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/collect/predicates_of.rs Outdated Show resolved Hide resolved

lcnr reviewed Oct 23, 2025

View reviewed changes

tests/ui/sized-hierarchy/bound-on-assoc-type-projection.rs Show resolved Hide resolved

davidtwco force-pushed the sized-hierarchy-missing-default-bounds branch from 4440b69 to 82a4049 Compare October 24, 2025 14:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 25, 2025

bors merged commit f435972 into rust-lang:master Oct 25, 2025
12 checks passed

rustbot added this to the 1.92.0 milestone Oct 25, 2025

rustbot added the perf-regression Performance regression. label Oct 25, 2025

davidtwco deleted the sized-hierarchy-missing-default-bounds branch October 25, 2025 11:50

panstromek mentioned this pull request Oct 27, 2025

Replace NullOp::SizeOf and NullOp::AlignOf by lang items. #147793

Merged

This was referenced Oct 27, 2025

[beta] Clippy beta backport #148029

Closed

[beta-1.91] Add more context to the temporary lifetime extension FCW #148174

Closed

github-actions bot mentioned this pull request Oct 30, 2025

Toolchain upgrade to nightly-2025-12-23 flux-rs/flux#1345

Draft

Uh oh!

hir_analysis: add missing sizedness bounds #142712

hir_analysis: add missing sizedness bounds #142712

Uh oh!

Conversation

davidtwco commented Jun 19, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 19, 2025

Uh oh!

rustbot commented Jun 19, 2025

Uh oh!

This comment has been minimized.

davidtwco commented Jun 19, 2025

Uh oh!

davidtwco commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrochenkov commented Jun 19, 2025

Uh oh!

compiler-errors commented Jun 19, 2025

Uh oh!

Uh oh!

davidtwco commented Jun 23, 2025

Uh oh!

compiler-errors commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidtwco commented Jun 27, 2025

Uh oh!

This comment has been minimized.

davidtwco commented Jul 3, 2025

Uh oh!

davidtwco commented Jul 7, 2025

Uh oh!

bors commented Jul 7, 2025

Uh oh!

bors commented Jul 7, 2025

Uh oh!

davidtwco commented Jul 7, 2025

Uh oh!

This comment has been minimized.

Uh oh!

lcnr left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rustbot commented Oct 24, 2025

Uh oh!

davidtwco commented Oct 24, 2025

Uh oh!

bors commented Oct 24, 2025

Uh oh!

bors commented Oct 24, 2025

Uh oh!

bors commented Oct 25, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 25, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 25, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

panstromek commented Oct 27, 2025

Uh oh!

davidtwco commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

davidtwco commented Jun 19, 2025 •

edited by rustbot

Loading

davidtwco commented Jun 19, 2025 •

edited

Loading

compiler-errors commented Jun 27, 2025 •

edited

Loading

lcnr left a comment •

edited by rustbot

Loading