Skip to content

Fix FnOnce impl for AsyncFn/AsyncFnMut self-borrowing closures in new solver #141359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented May 21, 2025

This only affects closures that are "AsyncFn/AsyncFnMut" in their calling capability that are being called with the FnOnce trait.

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 21, 2025
@lcnr
Copy link
Contributor

lcnr commented May 21, 2025

This only affects closures that are only "AsyncFnOnce" in their calling capability that are being called with the FnOnce trait.

That are not AsyncFnOnce? as in, it affects async Fn(Mut) closures?

@compiler-errors
Copy link
Member Author

Oops yep. Got the polarity backwards.

@compiler-errors compiler-errors changed the title Fix FnOnce impl for AsyncFnOnce self-borrowing closures in new solver Fix FnOnce impl for AsyncFn/AsyncFnMut self-borrowing closures in new solver May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants