Skip to content

Remove a test that never runs #140155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Apr 22, 2025

The coretests crate doesn't have the debug_typeid feature, so this test will always be configured out.

The coretests crate doesn't have the debug_typeid feature, so this test
will always be configured out.
@rustbot
Copy link
Collaborator

rustbot commented Apr 22, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 22, 2025
@compiler-errors
Copy link
Member

compiler-errors commented Apr 22, 2025

This was added by @kpreid in #136148. @Mark-Simulacrum had some feelings about feature = "..." based gating in libcore/libstd.

I don't see much value in just removing the test if we're keeping all the other gated stuff in, though? I assume we should just fix the feature gating of coretest?

@kpreid
Copy link
Contributor

kpreid commented Apr 22, 2025

To give some context, I probably originally wrote PR #136148 before the coretests split (#135937) was merged, so the test would have been in core itself and subject to its features.

I don't have any particular opinion on what should happen to this test, other than: won't we eventually want coretests to be able to test features of core, even if this one test is not highly valuable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants