Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io: Avoid marking some bytes as uninit #139068

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Mar 28, 2025

These bytes were marked as uninit, which would cause them to be initialized multiple times even though it was not necessary.

@rustbot
Copy link
Collaborator

rustbot commented Mar 28, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 28, 2025
@rust-log-analyzer

This comment has been minimized.

@joboet
Copy link
Member

joboet commented Apr 3, 2025

All right, let's ship it!
@bors r+
r? joboet

@bors
Copy link
Collaborator

bors commented Apr 3, 2025

📌 Commit 8787868 has been approved by joboet

It is now in the queue for this repository.

@rustbot rustbot assigned joboet and unassigned thomcc Apr 3, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2025
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#138017 (Tighten up assignment operator representations.)
 - rust-lang#138462 (Dedup `&mut *` reborrow suggestion in loops)
 - rust-lang#138610 (impl !PartialOrd for HirId)
 - rust-lang#138767 (Allow boolean literals in `check-cfg`)
 - rust-lang#139068 (io: Avoid marking some bytes as uninit)
 - rust-lang#139255 (Remove unused variables generated in merged doctests)
 - rust-lang#139270 (Add a mailmap entry for myself)
 - rust-lang#139303 (Put Noratrieb on vacation)
 - rust-lang#139312 (add Marco Ieni to mailmap)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ff8f2ef into rust-lang:master Apr 4, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 4, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 4, 2025
Rollup merge of rust-lang#139068 - a1phyr:less_uninit, r=joboet

io: Avoid marking some bytes as uninit

These bytes were marked as uninit, which would cause them to be initialized multiple times even though it was not necessary.
@a1phyr a1phyr deleted the less_uninit branch April 4, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants