Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uses_power_alignment: wording tweaks #139059

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

uses_power_alignment: wording tweaks #139059

wants to merge 2 commits into from
+14 −21

Conversation

RalfJung
Copy link
Member

Slightly improves the wording introduced with #135552.

@rustbot
Copy link
Collaborator

rustbot commented Mar 28, 2025

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 28, 2025
@RalfJung RalfJung force-pushed the uses_power_alignment branch from 661de9f to 83a3329 Compare March 28, 2025 17:34
@RalfJung
Copy link
Member Author

r? @workingjubilee
Seems like there's new developments, I'll update the PR once we figure out what we should say here.

@rustbot rustbot assigned workingjubilee and unassigned estebank Mar 29, 2025
@workingjubilee workingjubilee added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2025
@RalfJung RalfJung force-pushed the uses_power_alignment branch from 83a3329 to 8fca246 Compare April 1, 2025 14:31
@RalfJung RalfJung force-pushed the uses_power_alignment branch from 8fca246 to 87ff60c Compare April 1, 2025 14:33
@RalfJung
Copy link
Member Author

RalfJung commented Apr 1, 2025

I've updated the PR. Obviously we'll want more updates to eventually fix the alignment of f64, but that's a bigger change.

I also noticed an odd variable name, first_field_def for what is clearly not the first field but the "current" field, so I fixed that. And then I realized the code can be simplified quite a bit so I did that instead. ;)

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 1, 2025
@RalfJung RalfJung mentioned this pull request Apr 1, 2025
Merged
RalfJung
RalfJung commented Apr 1, 2025
View reviewed changes
compiler/rustc_lint/src/types.rs
@@ -1621,15 +1623,13 @@ impl ImproperCTypesDefinitions {
cx: &LateContext<'tcx>,
ty: Ty<'tcx>,
) -> bool {
assert!(cx.tcx.sess.target.os == "aix");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function should be dead code on non-AIX targets so I was confused why it would check the target again here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@workingjubilee workingjubilee

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @rustbot @estebank @workingjubilee