Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Fix build for NuttX targets #138972

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

std: Fix build for NuttX targets #138972

wants to merge 1 commit into from
+3 −0

Conversation

thaliaarchi
Copy link
Contributor

Fix std build for all NuttX targets. It is the single largest set of failures on https://does-it-build.noratrieb.dev/. Although, ESP-IDF also requires these same gates, there are other issues for those targets.

This can verified be running x check library/std --target= for all NuttX targets.

cc @no1wudi

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 26, 2025
no1wudi
no1wudi approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@no1wudi no1wudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

BTW, the missing SIGABRT will be fixed by rust-lang/libc#4353

@thaliaarchi
Copy link
Contributor Author

Nice! When I saw the missing SIGABRT via x check library, I decided to scale back my ambition and only fix x check library/std for now, haha.

@bors
Copy link
Collaborator

bors commented Apr 5, 2025

☔ The latest upstream changes (presumably #139401) made this pull request unmergeable. Please resolve the merge conflicts.

@thaliaarchi
std: Fix build for NuttX targets
0acac2c 
Fix std build for all NuttX targets. It is the single largest set of
failures on <https://does-it-build.noratrieb.dev/>. Although, ESP-IDF
also requires these same gates, there are other issues for those
targets.

This can verified be running `x check library/std --target=` for all
NuttX targets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@no1wudi no1wudi no1wudi approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thaliaarchi @rustbot @bors @no1wudi @Mark-Simulacrum