-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize the avx512 target features #138940
base: master
Are you sure you want to change the base?
Conversation
r? @davidtwco rustbot has assigned @davidtwco. Use |
|
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
1be9f75
to
94d0e36
Compare
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
Nominating for T-lang FCP. This stabilizes the AVX512 target features which is a per-requisite for stabilizing the AVX-512 intrinsics tracked in #111137. |
Can you also send a PR to update https://github.com/rust-lang/reference/blob/master/src/attributes/codegen.md#x86-or-x86_64? |
94d0e36
to
a3c822a
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These features are for the various AVX512 sub-features. We have already stabilized some of these names in is_x86_feature_detected!
so the language level name should match.
This PR stabilizes the AVX512 target features - see this comment.
Tracking Issue - #44839
DO NOT MERGE now, because the runtime detection for 5 features are guarded on
avx512_target_feature
, so rust-lang/stdarch#1757 has a temporary fix which changes the feature name of these. We need to FCP these together with all the AVX512 target features, after that and merge of rust-lang/stdarch#1760, we can again do a stdarch update and merge this.The target feature UI tests have been changed to
cmpxchg16b
(arbitrarily chosen, please comment if some other feature will be better)Updates
stdarch
Needs to wait for bootstrap bump due to s390x target features not being available in bootstrap (#139279)