core: use specialization for more methods of impl Iterator for &mut I
#138862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Noratrieb rustbot has assigned @Noratrieb. Use |
rustbot
added
S-waiting-on-review
joboet
force-pushed
the
spec_iterator_by_ref
branch
from
a23180d to
c73f31f
Compare
This comment has been minimized.
This comment has been minimized.
...and get rid of `ByRefSized`. Most of the iterator methods can be forwarded to the inner iterator if we know that it is `Sized`, but this is currently only done for `fold` and `try_fold`. This PR adds the optimization for all applicable methods. It uses two private helper struct to hide the specialization from the public API: * `Iterator for ByRefDefault` only forwards the methods that can be used even when the iterator is not `Sized`, all other methods are left to the default. * `Iterator for ByRef` specializes on `Sized` and forwards to either the underlying iterator or to `ByRefDefault` This PR also removes `ByRefSized`, the `Iterator for &mut I` should now be good enough to be used everywhere.
joboet
force-pushed
the
spec_iterator_by_ref
branch
from
c73f31f to
3815e24
Compare
|
r? The8472 |
|
☔ The latest upstream changes (presumably #139430) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and get rid of
ByRefSized. Most of the iterator methods can be forwarded to the inner iterator if we know that it isSized, but this is currently only done forfoldandtry_fold. This PR adds the optimization for all applicable methods. It uses two private helper struct to hide the specialization from the public API:Iterator for ByRefDefaultonly forwards the methods that can be used even when the iterator is notSized, all other methods are left to the default.Iterator for ByRefspecializes onSizedand forwards to either the underlying iterator or toByRefDefaultThis PR also removes
ByRefSized, theIterator for &mut Ishould now be good enough to be used everywhere.