Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert wf sized check on beta #138122

Closed
wants to merge 2 commits into from
Closed

Revert wf sized check on beta #138122

wants to merge 2 commits into from

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Mar 6, 2025 •
edited
Loading

Revert #136274 on beta. See #137186 (comment).

This was fixed by #137298 on master, but that PR includes some non-trivial changes to the way we do typechecking and wfchecking in the compiler, and while I'm confident about the implementation, there is a chance it introduces new cycle errors or something, so I'd prefer if we actually let this bake the proper amount.

@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Mar 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2025

Some changes occurred in tests/rustdoc-json

cc @aDotInTheVoid

@compiler-errors compiler-errors added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Mar 6, 2025
@cuviper
Copy link
Member

cuviper commented Mar 7, 2025

Meta tip: rustbot now understands when [beta is in the title that it is meant to target this branch. The bracket is because we usually write [beta] or [beta-1.x] as a prefix.

@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 13, 2025
@cuviper cuviper mentioned this pull request Mar 15, 2025
Merged
@cuviper cuviper added this to the 1.86.0 milestone Mar 15, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 15, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 16, 2025
@bors
Auto merge of rust-lang#138525 - cuviper:beta-next, r=cuviper
cb421c7 
[beta] backports

- Windows: Fix error in `fs::rename` on Windows 1607 rust-lang#137528
- rustdoc: when merging target features, keep the highest stability rust-lang#137632
- doctests: fix merging on stable rust-lang#137899
- Revert wf sized check on beta rust-lang#138122

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 16, 2025
@bors
Auto merge of rust-lang#138525 - cuviper:beta-next, r=cuviper
8c7969a 
[beta] backports

- Windows: Fix error in `fs::rename` on Windows 1607 rust-lang#137528
- rustdoc: when merging target features, keep the highest stability rust-lang#137632
- doctests: fix merging on stable rust-lang#137899
- Revert wf sized check on beta rust-lang#138122

r? cuviper
@cuviper
Copy link
Member

cuviper commented Mar 17, 2025

Merged in #138525.

@cuviper cuviper closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wesleywiser wesleywiser

Labels
A-rustdoc-json Area: Rustdoc JSON backend A-rustdoc-search Area: Rustdoc's search feature beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @cuviper @apiraino @wesleywiser