Demote i686-pc-windows-gnu to Tier 2 #137869

Noratrieb · 2025-03-01T21:23:45Z

In accordance with RFC 3771. FCP has been completed.

tracking issue #138422

I also added a stub doc page for the target and renamed the windows-gnullvm page for consistency.

rustbot · 2025-03-01T21:23:49Z

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Noratrieb · 2025-03-01T21:24:46Z

r? Kobzol you can take a look at the CI stuff already

Kobzol

Infra changes look good, left one comment. Good riddance, 32-bit legacy mess!

src/ci/github-actions/jobs.yml

Kobzol · 2025-03-02T09:54:52Z

src/ci/github-actions/jobs.yml

@@ -528,31 +527,6 @@ auto:
  # came from the mingw-w64 SourceForge download site. Unfortunately
  # SourceForge is notoriously flaky, so we mirror it on our own infrastructure.

-  # i686-mingw is split into three jobs to run tests in parallel.


src/doc/rustc/src/platform-support/windows-gnu.md

rustbot · 2025-03-11T20:35:13Z

These commits modify compiler targets.
(See the Target Tier Policy.)

Noratrieb · 2025-03-11T20:36:18Z

r? workingjubilee

I want to give you the honor of the bors r plus

src/bootstrap/mk/Makefile.in

workingjubilee · 2025-04-02T06:49:17Z

Want to hear a joke?

@bors r+

bors · 2025-04-02T06:49:19Z

📌 Commit 78db5a6 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2025-04-02T07:49:12Z

☔ The latest upstream changes (presumably #139229) made this pull request unmergeable. Please resolve the merge conflicts.

Noratrieb · 2025-04-02T16:37:04Z

that was an exceptionally good joke but now i have merge conflicts

In accordance with RFC 3771. I also added a stub doc page for the target and renamed the windows-gnullvm page for consistency.

workingjubilee · 2025-04-02T22:21:44Z

"32-bit Windows GNU".

@bors r+

bors · 2025-04-02T22:21:47Z

📌 Commit 6a1f57d has been approved by workingjubilee

It is now in the queue for this repository.

…he_destroyer_of_i686-pc-windows-gnu, r=workingjubilee Demote i686-pc-windows-gnu to Tier 2 In accordance with [RFC 3771](rust-lang/rfcs#3771). FCP has been completed. tracking issue rust-lang#138422 I also added a stub doc page for the target and renamed the windows-gnullvm page for consistency.

Rollup of 14 pull requests Successful merges: - rust-lang#137869 (Demote i686-pc-windows-gnu to Tier 2) - rust-lang#137880 (Autodiff batching) - rust-lang#138546 (Add integer to string formatting tests) - rust-lang#138947 (Refactor Apple version handling in the compiler) - rust-lang#138950 (replace extra_filename with strict version hash in metrics file names) - rust-lang#139213 (Run coretests and alloctests with cg_clif in CI) - rust-lang#139274 (Rustdoc: typecheck settings.js) - rust-lang#139295 (Remove creation of duplicate `AnonPipe`) - rust-lang#139298 (Allow for missing invisible close delim when reparsing an expression.) - rust-lang#139313 (Deduplicate some `rustc_middle` function bodies by calling the `rustc_type_ir` equivalent) - rust-lang#139317 (compiletest: Encapsulate all of the code that touches libtest) - rust-lang#139322 (Add helper function for checking LLD usage to `run-make-support`) - rust-lang#139335 (Pass correct param-env to `error_implies`) - rust-lang#139342 (Add a mailmap entry for myself) Failed merges: - rust-lang#138949 (Rename `is_like_osx` to `is_like_darwin`) r? `@ghost` `@rustbot` modify labels: rollup

…he_destroyer_of_i686-pc-windows-gnu, r=workingjubilee Demote i686-pc-windows-gnu to Tier 2 In accordance with [RFC 3771](rust-lang/rfcs#3771). FCP has been completed. tracking issue rust-lang#138422 I also added a stub doc page for the target and renamed the windows-gnullvm page for consistency.

bors · 2025-04-04T15:45:07Z

⌛ Testing commit 6a1f57d with merge 5337252...

bors · 2025-04-04T18:50:36Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 5337252 to master...

github-actions · 2025-04-04T18:52:37Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b8ff7b6 (parent) -> 5337252 (this PR)

Test differences

No test diffs found

Job duration changes

x86_64-apple-2: 3902.0s -> 7216.6s (84.9%)
x86_64-apple-1: 7376.5s -> 8883.2s (20.4%)
x86_64-mingw-1: 9141.6s -> 9826.8s (7.5%)
dist-x86_64-msvc-alt: 7256.3s -> 7729.3s (6.5%)
aarch64-gnu: 6464.3s -> 6859.3s (6.1%)
x86_64-gnu-llvm-19-2: 6091.1s -> 6367.9s (4.5%)
x86_64-gnu-nopt: 5643.6s -> 5808.0s (2.9%)
x86_64-gnu-llvm-18-3: 6772.5s -> 6955.5s (2.7%)
dist-x86_64-apple: 9223.4s -> 9453.0s (2.5%)
dist-various-2: 3341.2s -> 3422.2s (2.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-04-04T20:42:26Z

Finished benchmarking commit (5337252): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 781.07s -> 779.508s (-0.20%)
Artifact size: 365.97 MiB -> 365.96 MiB (-0.00%)

rustbot assigned ehuss Mar 1, 2025

rustbot assigned Kobzol and unassigned ehuss Mar 1, 2025

Kobzol reviewed Mar 2, 2025

View reviewed changes

bjorn3 reviewed Mar 2, 2025

View reviewed changes

src/doc/rustc/src/platform-support/windows-gnu.md Outdated Show resolved Hide resolved

Noratrieb force-pushed the Now_I_am_become_death,_the_destroyer_of_i686-pc-windows-gnu branch 2 times, most recently from 5e115aa to 77677fe Compare March 9, 2025 12:01

Noratrieb marked this pull request as ready for review March 11, 2025 20:35

rustbot assigned workingjubilee and unassigned Kobzol Mar 11, 2025

Noratrieb mentioned this pull request Mar 12, 2025

Tracking Issue for the demotion of i686-pc-windows-gnu #138422

Open

4 tasks

jieyouxu reviewed Mar 17, 2025

View reviewed changes

src/bootstrap/mk/Makefile.in Outdated Show resolved Hide resolved

Noratrieb force-pushed the Now_I_am_become_death,_the_destroyer_of_i686-pc-windows-gnu branch from 77677fe to 78db5a6 Compare March 24, 2025 19:06

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 2, 2025

Demote i686-pc-windows-gnu to Tier 2

6a1f57d

In accordance with RFC 3771. I also added a stub doc page for the target and renamed the windows-gnullvm page for consistency.

Noratrieb force-pushed the Now_I_am_become_death,_the_destroyer_of_i686-pc-windows-gnu branch from 78db5a6 to 6a1f57d Compare April 2, 2025 19:41

Noratrieb added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 2, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025

Zalathar mentioned this pull request Apr 4, 2025

Rollup of 14 pull requests #139344

Closed

Zalathar mentioned this pull request Apr 4, 2025

Rollup of 8 pull requests #139358

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 4, 2025

bors merged commit 5337252 into rust-lang:master Apr 4, 2025
7 checks passed

rustbot added this to the 1.88.0 milestone Apr 4, 2025

bors mentioned this pull request Apr 4, 2025

redesign stage 0 std #119899

Open

Noratrieb deleted the Now_I_am_become_death,_the_destroyer_of_i686-pc-windows-gnu branch April 4, 2025 19:38

This was referenced Apr 4, 2025

Make target maintainers more easily pingable #139028

Merged

Rollup of 5 pull requests #139377

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Demote i686-pc-windows-gnu to Tier 2 #137869

Demote i686-pc-windows-gnu to Tier 2 #137869

Noratrieb commented Mar 1, 2025 •

edited

Loading

rustbot commented Mar 1, 2025

Noratrieb commented Mar 1, 2025

Kobzol left a comment

Kobzol Mar 2, 2025

rustbot commented Mar 11, 2025

Noratrieb commented Mar 11, 2025

workingjubilee commented Apr 2, 2025

bors commented Apr 2, 2025

bors commented Apr 2, 2025

Noratrieb commented Apr 2, 2025

workingjubilee commented Apr 2, 2025

bors commented Apr 2, 2025

bors commented Apr 4, 2025

bors commented Apr 4, 2025

github-actions bot commented Apr 4, 2025

rust-timer commented Apr 4, 2025

Demote i686-pc-windows-gnu to Tier 2 #137869

Demote i686-pc-windows-gnu to Tier 2 #137869

Conversation

Noratrieb commented Mar 1, 2025 • edited Loading

rustbot commented Mar 1, 2025

Noratrieb commented Mar 1, 2025

Kobzol left a comment

Choose a reason for hiding this comment

Kobzol Mar 2, 2025

Choose a reason for hiding this comment

rustbot commented Mar 11, 2025

Noratrieb commented Mar 11, 2025

workingjubilee commented Apr 2, 2025

bors commented Apr 2, 2025

bors commented Apr 2, 2025

Noratrieb commented Apr 2, 2025

workingjubilee commented Apr 2, 2025

bors commented Apr 2, 2025

bors commented Apr 4, 2025

bors commented Apr 4, 2025

github-actions bot commented Apr 4, 2025

Test differences

Job duration changes

rust-timer commented Apr 4, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Noratrieb commented Mar 1, 2025 •

edited

Loading