update doc for Vec::into_boxed_slice #137546
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
also note #135933 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
xizheyin
reviewed
Mar 18, 2025
| /// assert_eq!(slice.into_vec().capacity(), 3); | ||
| /// let new_vec = slice.into_vec(); | ||
| /// // The allocator may have kept extra capacity: | ||
| /// assert!(new_vec.capacity() >= 3); |
There was a problem hiding this comment.
I'm curious about the test. I tried many times with assert_eq!(slice.into_vec().capacity(), 3);, it all passed. And I tested it for different types and cases. Only ZST kept extra capacity. Experiment result is here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Vec::into_boxed_sliceto highlight the API dependency on the memory layout strategy, and the doctest to remove the "encoding" of exact capacity guarantee.Related issue
Vec::into_boxed_sliceno-excess guarantee regressed in 1.77.0 #125941r? @the8472