Add exclude to config.toml #137147

Shourya742 · 2025-02-16T18:00:28Z

Closes: #35678

r? @onur-ozkan

try-job: x86_64-msvc-2

rustbot · 2025-02-16T18:00:37Z

This PR modifies config.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

bors · 2025-02-18T04:33:42Z

☔ The latest upstream changes (presumably #137176) made this pull request unmergeable. Please resolve the merge conflicts.

config.example.toml

onur-ozkan · 2025-02-23T05:55:17Z

@rustbot author

bors · 2025-02-23T09:03:03Z

☔ The latest upstream changes (presumably #137215) made this pull request unmergeable. Please resolve the merge conflicts.

Shourya742 · 2025-02-24T04:56:53Z

@rustbot review

bors · 2025-02-25T20:30:39Z

☔ The latest upstream changes (presumably #137611) made this pull request unmergeable. Please resolve the merge conflicts.

onur-ozkan

LGTM

onur-ozkan · 2025-03-01T06:17:15Z

@bors r+

bors · 2025-03-01T06:17:17Z

📌 Commit a110552 has been approved by onur-ozkan

It is now in the queue for this repository.

Shourya742 · 2025-03-01T07:22:35Z

@rustbot review
cc: @onur-ozkan

onur-ozkan · 2025-03-01T08:53:02Z

Rebase wasn't required, it was already queued.

Again, @bors r+

bors · 2025-03-01T08:53:05Z

📌 Commit 9206960 has been approved by onur-ozkan

It is now in the queue for this repository.

Shourya742 · 2025-03-01T10:49:29Z

Rebase wasn't required, it was already queued.

Again, @bors r+

I saw change_tracker conflicts on github, so thought of rebasing on latest changes on master. Does bors resolve merge conflicts??

bors · 2025-03-12T01:05:19Z

☔ The latest upstream changes (presumably #138366) made this pull request unmergeable. Please resolve the merge conflicts.

Shourya742 · 2025-03-12T03:21:58Z

@rustbot review

bors · 2025-03-13T14:25:33Z

☔ The latest upstream changes (presumably #138448) made this pull request unmergeable. Please resolve the merge conflicts.

onur-ozkan · 2025-03-15T07:02:17Z

@bors r+

bors · 2025-03-15T07:02:20Z

📌 Commit c6ecd8c has been approved by onur-ozkan

It is now in the queue for this repository.

Rollup of 16 pull requests Successful merges: - rust-lang#133055 (Expand `CloneToUninit` documentation.) - rust-lang#137147 (Add exclude to config.toml) - rust-lang#137864 (Don't drop `Rvalue::WrapUnsafeBinder` during GVN) - rust-lang#137890 (doc: clarify that consume can be called after BufReader::peek) - rust-lang#137956 (Add RTN support to rustdoc) - rust-lang#137968 (Properly escape regexes in Python scripts) - rust-lang#138082 (Remove `#[cfg(not(test))]` gates in `core`) - rust-lang#138275 (expose `is_s390x_feature_detected!` from `std::arch`) - rust-lang#138303 (Fix Ptr inconsistency in {Rc,Arc}) - rust-lang#138309 (Add missing doc for intrinsic (Fix PR135334)) - rust-lang#138323 (Expand and organize `offset_of!` documentation.) - rust-lang#138329 (debug-assert that the size_hint is well-formed in `collect`) - rust-lang#138465 (linkchecker: bump html5ever) - rust-lang#138471 (Clean up some tests in tests/ui) - rust-lang#138472 (Add codegen test for rust-lang#129795) - rust-lang#138484 (Use lit span when suggesting suffix lit cast) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#137147 - Shourya742:2025-02-16-support-exclude-in-config.toml, r=onur-ozkan Add exclude to config.toml Closes: rust-lang#35678 r? `@onur-ozkan` try-job: x86_64-msvc-2

RalfJung · 2025-03-17T08:08:43Z

src/bootstrap/src/utils/change_tracker.rs

+    ChangeInfo {
+        change_id: 137147,
+        severity: ChangeSeverity::Info,
+        summary: "New option `build.exclude` that adds support for excluding test.",


This should say "excluding tests", right?

Also, it's not just for tests. I missed this. ~~I will send a follow-up PR.~~

PR: #138592

Signed-off-by: onur-ozkan <[email protected]>

update change entry for rust-lang#137147 r? `@RalfJung`

Rollup of 9 pull requests Successful merges: - rust-lang#136355 (Add `*_value` methods to proc_macro lib) - rust-lang#137621 (Add std support to cygwin target) - rust-lang#137793 (Stablize anonymous pipe) - rust-lang#138341 (std: Mention clone-on-write mutation in Arc<T>) - rust-lang#138517 (Improve upvar analysis for deref of child capture) - rust-lang#138584 (Update Rust Foundation links in Readme) - rust-lang#138586 (Document `#![register_tool]`) - rust-lang#138590 (Flatten and simplify some control flow 🫓) - rust-lang#138592 (update change entry for rust-lang#137147) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#138592 - onur-ozkan:follow-up-137147, r=Kobzol update change entry for rust-lang#137147 r? `@RalfJung`

rustbot assigned onur-ozkan Feb 16, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 16, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from e9a9186 to 2bf009d Compare February 16, 2025 20:06

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from 2bf009d to 471069b Compare February 19, 2025 02:42

onur-ozkan reviewed Feb 23, 2025

View reviewed changes

config.example.toml Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from 471069b to daf8f8d Compare February 23, 2025 16:48

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 24, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from daf8f8d to a110552 Compare February 27, 2025 14:47

onur-ozkan approved these changes Mar 1, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from a110552 to 9206960 Compare March 1, 2025 07:21

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2025

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 12, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from d07eb8b to de54712 Compare March 12, 2025 03:04

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2025

Shourya742 added 5 commits March 13, 2025 21:37

add exclude to config.toml

ad74285

add test for exclude feature

7d1537e

Add change info to change tracker

22571da

make test platform agnostic

9d5f074

update the test_exclude to not use paths with path separators

c6ecd8c

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from de54712 to c6ecd8c Compare March 13, 2025 16:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2025

jieyouxu mentioned this pull request Mar 16, 2025

Rollup of 16 pull requests #138548

Merged

bors merged commit b8c51f4 into rust-lang:master Mar 16, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 16, 2025

RalfJung reviewed Mar 17, 2025

View reviewed changes

onur-ozkan added a commit to onur-ozkan/rust that referenced this pull request Mar 17, 2025

update change entry for rust-lang#137147

0d100d3

Signed-off-by: onur-ozkan <[email protected]>

jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 17, 2025

Rollup merge of rust-lang#138592 - onur-ozkan:follow-up-137147, r=Kobzol

87b87b1

update change entry for rust-lang#137147 r? `@RalfJung`

jhpratt mentioned this pull request Mar 17, 2025

Rollup of 9 pull requests #138595

Merged

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2025

Unrolled build for rust-lang#138592

2dda47f

Rollup merge of rust-lang#138592 - onur-ozkan:follow-up-137147, r=Kobzol update change entry for rust-lang#137147 r? `@RalfJung`

jhpratt mentioned this pull request Mar 18, 2025

Rollup of 12 pull requests #138636

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add exclude to config.toml #137147

Add exclude to config.toml #137147

Shourya742 commented Feb 16, 2025 •

edited by onur-ozkan

Loading

rustbot commented Feb 16, 2025

bors commented Feb 18, 2025

onur-ozkan commented Feb 23, 2025

bors commented Feb 23, 2025

Shourya742 commented Feb 24, 2025

bors commented Feb 25, 2025

onur-ozkan left a comment

onur-ozkan commented Mar 1, 2025

bors commented Mar 1, 2025

Shourya742 commented Mar 1, 2025 •

edited

Loading

onur-ozkan commented Mar 1, 2025

bors commented Mar 1, 2025

Shourya742 commented Mar 1, 2025 •

edited

Loading

bors commented Mar 12, 2025

Shourya742 commented Mar 12, 2025

bors commented Mar 13, 2025

onur-ozkan commented Mar 15, 2025

bors commented Mar 15, 2025

RalfJung Mar 17, 2025

onur-ozkan Mar 17, 2025 •

edited

Loading

Add exclude to config.toml #137147

Add exclude to config.toml #137147

Conversation

Shourya742 commented Feb 16, 2025 • edited by onur-ozkan Loading

rustbot commented Feb 16, 2025

bors commented Feb 18, 2025

onur-ozkan commented Feb 23, 2025

bors commented Feb 23, 2025

Shourya742 commented Feb 24, 2025

bors commented Feb 25, 2025

onur-ozkan left a comment

Choose a reason for hiding this comment

onur-ozkan commented Mar 1, 2025

bors commented Mar 1, 2025

Shourya742 commented Mar 1, 2025 • edited Loading

onur-ozkan commented Mar 1, 2025

bors commented Mar 1, 2025

Shourya742 commented Mar 1, 2025 • edited Loading

bors commented Mar 12, 2025

Shourya742 commented Mar 12, 2025

bors commented Mar 13, 2025

onur-ozkan commented Mar 15, 2025

bors commented Mar 15, 2025

RalfJung Mar 17, 2025

Choose a reason for hiding this comment

onur-ozkan Mar 17, 2025 • edited Loading

Choose a reason for hiding this comment

Shourya742 commented Feb 16, 2025 •

edited by onur-ozkan

Loading

Shourya742 commented Mar 1, 2025 •

edited

Loading

Shourya742 commented Mar 1, 2025 •

edited

Loading

onur-ozkan Mar 17, 2025 •

edited

Loading