-
Notifications
You must be signed in to change notification settings - Fork 13.3k
fix: minor typo fixes #134538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: minor typo fixes #134538
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Thanks for the fixes! Could you just squash this into one commit? Having distinct atomic history is usually a great thing, but three commits to change a total of four characters is a bit much. |
@tgross35 this got me thinking: maybe we should have a command for bors to tell it that we want it to squash everything into a single commit. This is not an uncommon request we have. |
glad this helped you. could you please merge it? |
@crStiv could you do |
I wish to but I use GitHub in my browser and not via my local machine |
Local development does tend to be pretty necessary to help out here :) Getting started is pretty easy, we have some instructions at https://rustc-dev-guide.rust-lang.org/building/how-to-build-and-run.html. |
There have been a large number of typo-fixing commits lately that require large amounts of effort to help the author "over the line" when we ask them to do small tasks like squashing commits. We do not want unnecessary churn for the compiler and none of these are user-facing. I am sorry @crStiv but I am closing this per #58619 |
Address several minor typographical errors in the following files:
.github/workflows/ci.yml
: Fixed a typo in a comment for theoutcome
job.compiler/rustc_arena/src/lib.rs
: Corrected a typo in a comment related to theTypedArena
implementation.compiler/rustc_ast_passes/src/ast_validation.rs
: Fixed a typo in a comment describing the removal of a where bound.