Skip to content

fix: minor typo fixes #134538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: minor typo fixes #134538

wants to merge 3 commits into from

Conversation

crStiv
Copy link

@crStiv crStiv commented Dec 19, 2024

Address several minor typographical errors in the following files:

  1. .github/workflows/ci.yml: Fixed a typo in a comment for the outcome job.
  2. compiler/rustc_arena/src/lib.rs: Corrected a typo in a comment related to the TypedArena implementation.
  3. compiler/rustc_ast_passes/src/ast_validation.rs: Fixed a typo in a comment describing the removal of a where bound.

divided "isused" into "is used"
"similarlty" to "similarity"
"th eonly" to "the only"
@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 19, 2024
@tgross35
Copy link
Contributor

Thanks for the fixes! Could you just squash this into one commit? Having distinct atomic history is usually a great thing, but three commits to change a total of four characters is a bit much.

@dianqk dianqk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2024
@estebank
Copy link
Contributor

@tgross35 this got me thinking: maybe we should have a command for bors to tell it that we want it to squash everything into a single commit. This is not an uncommon request we have.

@crStiv
Copy link
Author

crStiv commented Dec 31, 2024

@tgross35 this got me thinking: maybe we should have a command for bors to tell it that we want it to squash everything into a single commit. This is not an uncommon request we have.

glad this helped you. could you please merge it?

@estebank
Copy link
Contributor

@crStiv could you do git rebase -i HEAD^^^ and then change the second and third line in the editor that will appear to replace pick with s (for "squash"). This will merge the three commits into one and then we can merge the pr. Happy new year!

@crStiv
Copy link
Author

crStiv commented Jan 2, 2025

@crStiv could you do git rebase -i HEAD^^^ and then change the second and third line in the editor that will appear to replace pick with s (for "squash"). This will merge the three commits into one and then we can merge the pr. Happy new year!

I wish to but I use GitHub in my browser and not via my local machine

@tgross35
Copy link
Contributor

tgross35 commented Jan 2, 2025

Local development does tend to be pretty necessary to help out here :) Getting started is pretty easy, we have some instructions at https://rustc-dev-guide.rust-lang.org/building/how-to-build-and-run.html.

@workingjubilee
Copy link
Member

There have been a large number of typo-fixing commits lately that require large amounts of effort to help the author "over the line" when we ask them to do small tasks like squashing commits. We do not want unnecessary churn for the compiler and none of these are user-facing. I am sorry @crStiv but I am closing this per #58619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants