-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm-wrapper: Pass newly added param to DIBuilder::createStaticMemberType() #117948
Conversation
…rType() This was added in llvm/llvm-project#72234. DW_TAG_member was the implicit default before.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
This comment has been minimized.
This comment has been minimized.
@bors r+ rollup |
Er, hang on. https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/23773 looks like this didn't compile on LLVM 18 either? @bors r- |
that's from a different change that landed <1hr ago: llvm/llvm-project#72011 |
#117954 to fix that one |
@bors r+ rollup |
llvm-wrapper: Pass newly added param to DIBuilder::createStaticMemberType() This was added in llvm/llvm-project#72234. DW_TAG_member was the implicit default before. The LLVM change is quite sinister since due to weakly typed ints and default params, this was still successfully compiling against LLVM but was passing the wrong parameters.
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
looks like a flake, will need another merge attempt |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (6faa181): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 675.491s -> 676.425s (0.14%) |
This was added in llvm/llvm-project#72234.
DW_TAG_member was the implicit default before.
The LLVM change is quite sinister since due to weakly typed ints and default params, this was still successfully compiling against LLVM but was passing the wrong parameters.