Skip to content

Update Clippy #113686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 126 commits into from
Jul 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
126 commits
Select commit Hold shift + click to select a range
c5a9adc
new lint: `type_id_on_box`
y21 Jun 18, 2023
9ab1e8e
that was definitely not the right version
y21 Jun 18, 2023
26ac76c
add it to the methods lint pass
y21 Jun 18, 2023
b0dfecd
add a few more test cases
y21 Jun 18, 2023
1b6738b
s/is_dyn_trait/is_dyn_any
y21 Jun 20, 2023
7bd8ab7
Make simd_shuffle_indices use valtrees
oli-obk Jun 16, 2023
d69c4f5
Add `SPEEDTEST`
blyxyas Jun 10, 2023
0cd8bbc
Fix dogfood
blyxyas Jun 10, 2023
57923c3
Finally fix dogfood
blyxyas Jun 28, 2023
4340a8a
Use depinfo to discover UI test dependencies
Alexendoo Jun 28, 2023
86391ab
Don't lint manual_let_else in cases where the question mark operator …
est31 Jun 11, 2023
c6be621
Fix the now stricter lint in manual_rem_euclid.rs
est31 Jun 11, 2023
20dfaba
Put into one pass
est31 Jun 30, 2023
2f7f139
Use `cargo build --tests` in CI
Alexendoo Jun 30, 2023
420f3d1
"try this" -> "try"
smoelius Jul 1, 2023
bb33e03
Auto merge of #112718 - oli-obk:SIMD-destructure_mir_const, r=cjgillot
bors Jul 2, 2023
885a182
Fix typos
Centri3 Jul 2, 2023
1990b72
Auto merge of #11058 - Centri3:typos, r=xFrednet
bors Jul 2, 2023
17a48c2
Auto merge of #11053 - Alexendoo:ci-build-tests, r=flip1995
bors Jul 2, 2023
cb3ecf7
Merge commit '37f4c1725d3fd7e9c3ffd8783246bc5589debc53' into clippyup
flip1995 Jul 2, 2023
ba1ffec
Fix valtree changes
flip1995 Jul 2, 2023
4aa4fec
Fix compile-test tests to work with the new ui_test crate
flip1995 Jul 2, 2023
e29a5ac
let_and_return: lint 'static lifetimes, don't lint borrows in closures
Alexendoo Jul 2, 2023
83d0682
Auto merge of #11061 - Alexendoo:let-and-return-closures, r=llogiq
bors Jul 2, 2023
ea4ca22
Auto merge of #10920 - blyxyas:speedtest, r=llogiq
bors Jul 2, 2023
555ceb8
[`missing_fields_in_debug`]: make sure `self` is an adt
y21 Jul 2, 2023
4752466
Auto merge of #11069 - y21:issue11063, r=Alexendoo
bors Jul 2, 2023
c46ddeb
Auto merge of #10987 - y21:type_id_on_box, r=llogiq
bors Jul 3, 2023
6990eaa
Don't suppress manual_let_else if question_mark is allowed
est31 Jul 2, 2023
d80581c
Move pat_and_expr_can_be_question_mark into clippy_utils
est31 Jul 3, 2023
75c339c
[`arc_with_non_send_sync`]: look for nested type parameters
y21 Jul 3, 2023
2b03bb0
Auto merge of #11077 - y21:issue11076, r=Manishearth
bors Jul 3, 2023
9a58107
Fix FP [`needless_raw_string_hashes`]
Centri3 Jul 3, 2023
1f77f8c
[`useless_vec`]: use the source span
y21 Jul 3, 2023
a959061
Auto merge of #11081 - y21:issue11075, r=Manishearth
bors Jul 3, 2023
3f17c5c
Auto merge of #10924 - est31:manual_let_else_question_mark, r=Centri3…
bors Jul 3, 2023
ba3bd8f
Auto merge of #11078 - Centri3:11068, r=llogiq
bors Jul 3, 2023
b4549c5
[`useless_vec`]: add more tests for macro combinations
y21 Jul 3, 2023
b41fc67
Add needless_pass_by_ref lint
GuillaumeGomez Jun 6, 2023
a43bea1
Add UI test for `needless_pass_by_ref_mut`
GuillaumeGomez Jun 6, 2023
c62c7fa
Update UI tests with new `needless_pass_by_ref_mut` lint
GuillaumeGomez Jun 15, 2023
dd3e00f
Fix warnings of `needless_pass_by_ref_mut` in clippy
GuillaumeGomez Jun 15, 2023
33adfcd
Add warning for `NEEDLESS_PASS_BY_REF_MUT` lint about the fact that i…
GuillaumeGomez Jul 3, 2023
8fad54e
new lint: `read_line_without_trim`
y21 Jun 16, 2023
85f535b
add test cases for u32, f32, bool, String
y21 Jul 3, 2023
3f4e599
Auto merge of #11094 - y21:issue11084, r=Alexendoo
bors Jul 3, 2023
f048f73
Add warning about semver compatibility if it's a public function
GuillaumeGomez Jul 4, 2023
1e656d8
Auto merge of #10970 - y21:read_line_without_trim, r=giraffate
bors Jul 5, 2023
4062418
Deal with fallout
BoxyUwU Jul 4, 2023
6868c0a
[`unnecessary_literal_unwrap`]: don't lint if binding initializer is …
y21 Jul 5, 2023
a4f9914
Patch clippy
oli-obk Jul 5, 2023
f945351
Fix regex lints for regex 1.9.0
Alexendoo Jul 5, 2023
cbe4682
Move `TyCtxt::mk_x` to `Ty::new_x` where applicable
BoxyUwU Jul 5, 2023
8aca068
Auto merge of #113291 - oli-obk:pretty_print_mir_const, r=RalfJung
bors Jul 6, 2023
8c70e52
Auto merge of #113377 - BoxyUwU:move_ty_ctors_to_ty, r=compiler-errors
bors Jul 6, 2023
dd8e44c
Auto merge of #11111 - Alexendoo:regex-def-paths, r=giraffate
bors Jul 6, 2023
f12edfd
`manual_float_methods`
Centri3 Jun 30, 2023
5949f76
Make suggestion give multiple alternatives
Centri3 Jul 2, 2023
4939a71
arc_with_non_send_sync: reword and move to suspicious
Alexendoo Jul 4, 2023
26edd5a
Auto merge of #11104 - Alexendoo:arc-with-non-send-sync, r=Centri3
bors Jul 7, 2023
2865526
Fix changelog PR listings, create them automatically in `fetch_prs_be…
Alexendoo Jul 6, 2023
5cc0c04
[`manual_range_patterns`]: lint negative values
y21 Jul 3, 2023
c927912
[`manual_range_patterns`]: document what range we don't lint
y21 Jul 6, 2023
b5ac726
Rename `adjustment::PointerCast` and variants using it to `PointerCoe…
Noratrieb Jul 5, 2023
87373d7
Fix failing clippy tests
Alexendoo Jul 7, 2023
5df1f66
Pass correct substs to `implements_trait` in `incorrect_impls`
Noratrieb Jul 7, 2023
2eff2f2
Auto merge of #11122 - Nilstrieb:SUBSTITUTION-INITIATED, r=flip1995
bors Jul 7, 2023
3a1fc26
Auto merge of #11114 - Alexendoo:changelog-prs-fetch, r=xFrednet
bors Jul 7, 2023
1816caa
Auto merge of #113376 - Nilstrieb:pointer-coercions-are-not-casts-bec…
bors Jul 8, 2023
31d50a6
Delete `to_string_in_format_args_incremental.rs`
Noratrieb Jul 8, 2023
b485e4f
Auto merge of #113450 - Nilstrieb:src/bootstrap/test.rs, r=flip1995
bors Jul 8, 2023
2a1fd22
implement `manual_partial_ord_impl`
Centri3 May 15, 2023
004e89d
rename to `manual_partial_ord_and_ord_impl`
Centri3 May 15, 2023
844afbf
use `other` instead of `self`
Centri3 Jun 15, 2023
a5dfb68
refactor
Centri3 Jun 30, 2023
41438c2
Refactor, remove `Constant::to_bits`
Centri3 Jul 4, 2023
e5db198
Auto merge of #10788 - Centri3:duplicate_manual_partial_ord_impl, r=x…
bors Jul 8, 2023
8e261c0
Auto merge of #11049 - Centri3:manual_is_infinite, r=blyxyas,xFrednet
bors Jul 8, 2023
2be695b
[significant_drop_tightening] Fix #11128
c410-f3r Jul 8, 2023
6384221
Dogfood
c410-f3r Jul 8, 2023
6ae065f
Auto merge of #11129 - c410-f3r:lock-1, r=Manishearth
bors Jul 8, 2023
b4738a6
Add test for #10535
smoelius Jul 8, 2023
3bf2138
Fix #10535
smoelius Jul 8, 2023
757fe49
Auto merge of #11130 - smoelius:fix-10535, r=Jarcho
bors Jul 9, 2023
b46033e
Auto merge of #10900 - GuillaumeGomez:needless-pass-by-ref, r=llogiq
bors Jul 9, 2023
ebd8d31
Auto merge of #11055 - smoelius:try-this, r=dswij
bors Jul 9, 2023
507d1c2
Auto merge of #11110 - y21:unnecessary_literal_unwrap_ignore_expn, r=…
bors Jul 9, 2023
9058b04
Auto merge of #11096 - y21:issue11091, r=giraffate
bors Jul 10, 2023
d1575d1
changelog: Fix typo in `needless_pass_by_ref_mut` lint description
GuillaumeGomez Jul 9, 2023
23ac723
adjust applicability and suggest making binding mutable
y21 Jun 23, 2023
9ab7137
Auto merge of #11133 - GuillaumeGomez:fix-description-typo, r=Manishe…
bors Jul 10, 2023
3be3fb7
Auto merge of #11016 - y21:issue10029, r=blyxyas,dswij
bors Jul 10, 2023
103949b
Drop uplifted `clippy::fn_null_check`
Urgau May 17, 2023
cd1c853
[`unnecessary_literal_unwrap`]: lint `unwrap_unchecked`
y21 Jul 3, 2023
0b5dac0
[`unnecessary_literal_unwrap`]: also handle unwrap_err_unchecked
y21 Jul 3, 2023
a8939e5
Auto merge of #111717 - Urgau:uplift_fn_null_check, r=oli-obk
bors Jul 11, 2023
31397b4
Update version attribute for 1.71 lints
xFrednet Jul 11, 2023
5ea622c
Changelog for Rust 1.71 :crown:
xFrednet Jul 11, 2023
7a3756a
Changelog: Add disclaimer about the new format
xFrednet Jul 12, 2023
660ef4f
Ignore flaky clippy tests.
ehuss Jul 12, 2023
c49c177
[`panic_in_result_fn`] remove `todo!`, `unimplemented!`, `unreachable!`
panosfol Jul 7, 2023
53d2938
Auto merge of #11045 - Alexendoo:extern-flags, r=flip1995
bors Jul 12, 2023
3b43b1e
Auto merge of #11098 - y21:issue11093, r=giraffate
bors Jul 12, 2023
c5fc61c
[`arithmetic_side_effect`]: allow different rhs type
y21 Jul 12, 2023
4102a30
[`tuple_array_conversions`]: move from `complexity` to `nursery`
MingweiSamuel Jul 12, 2023
d398e59
Auto merge of #11138 - xFrednet:changelog-1-71, r=flip1995
bors Jul 12, 2023
df92b52
Auto merge of #11123 - panosfol:master, r=giraffate
bors Jul 12, 2023
050b714
Add "Known problems" section to `needless_borrow` documentation
smoelius Jul 13, 2023
b10a0aa
Auto merge of #11148 - smoelius:nb-known-problems, r=Jarcho
bors Jul 13, 2023
631faa1
Auto merge of #11146 - hydro-project:tuple-array-conversions, r=Centr…
bors Jul 13, 2023
a0e8257
Auto merge of #11147 - y21:issue11145, r=Alexendoo
bors Jul 13, 2023
2811eff
Add `imports_granularity = "Module"` to rustfmt.toml
Alexendoo Jul 3, 2023
7ccf5d4
Auto merge of #11095 - Alexendoo:rustfmt-imports, r=Manishearth
bors Jul 13, 2023
ea36a9d
Set `unnecessary_cast` suggestion to `MaybeIncorrect` for pointer casts
Alexendoo Jul 13, 2023
36279f1
Trigger a rebuild when CLIPPY_CONF_DIR changes
Alexendoo Jul 13, 2023
4b355d8
Auto merge of #11154 - Alexendoo:track-clippy-conf-dir, r=flip1995
bors Jul 13, 2023
bafde54
Auto merge of #11152 - Alexendoo:unnecessary-cast-applicability, r=Ma…
bors Jul 14, 2023
415fdb2
Merge remote-tracking branch 'upstream/master' into rustup
flip1995 Jul 14, 2023
faa07d3
Bump Clippy version -> 0.1.73
flip1995 Jul 14, 2023
753c30f
Bump nightly version -> 2023-07-14
flip1995 Jul 14, 2023
1d33469
Auto merge of #11157 - flip1995:rustup, r=flip1995
bors Jul 14, 2023
498db80
don't hide lifetimes for `LateContext`
y21 Jul 16, 2023
d9c24d1
Auto merge of #11169 - y21:new_lint_unelide_lifetimes, r=xFrednet
bors Jul 16, 2023
561303d
Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup
flip1995 Jul 17, 2023
c2490bd
Update Cargo.lock/toml
flip1995 Jul 17, 2023
8ca13e8
Another fix for incorrect_impls
flip1995 Jul 17, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
35 changes: 13 additions & 22 deletions Cargo.lock
Original file line number Diff line number Diff line change
Expand Up @@ -513,16 +513,25 @@ checksum = "2da6da31387c7e4ef160ffab6d5e7f00c42626fe39aea70a7b0f1773f7dd6c1b"

[[package]]
name = "clippy"
version = "0.1.72"
version = "0.1.73"
dependencies = [
"clippy_lints",
"clippy_utils",
"derive-new",
"filetime",
"futures",
"if_chain",
"itertools",
"parking_lot 0.12.1",
"quote",
"regex",
"rustc_tools_util",
"serde",
"syn 2.0.8",
"tempfile",
"termize",
"tester",
"tokio",
"toml 0.7.5",
"ui_test",
"walkdir",
Expand All @@ -543,7 +552,7 @@ dependencies = [

[[package]]
name = "clippy_lints"
version = "0.1.72"
version = "0.1.73"
dependencies = [
"arrayvec",
"cargo_metadata",
Expand All @@ -566,27 +575,9 @@ dependencies = [
"url",
]

[[package]]
name = "clippy_test_deps"
version = "0.1.0"
dependencies = [
"clippy_lints",
"clippy_utils",
"derive-new",
"futures",
"if_chain",
"itertools",
"parking_lot 0.12.1",
"quote",
"regex",
"serde",
"syn 2.0.8",
"tokio",
]

[[package]]
name = "clippy_utils"
version = "0.1.72"
version = "0.1.73"
dependencies = [
"arrayvec",
"if_chain",
Expand Down Expand Up @@ -847,7 +838,7 @@ checksum = "a0afaad2b26fa326569eb264b1363e8ae3357618c43982b3f285f0774ce76b69"

[[package]]
name = "declare_clippy_lint"
version = "0.1.72"
version = "0.1.73"
dependencies = [
"itertools",
"quote",
Expand Down
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ members = [
"src/tools/cargotest",
"src/tools/clippy",
"src/tools/clippy/clippy_dev",
"src/tools/clippy/clippy_test_deps",
"src/tools/compiletest",
"src/tools/error_index_generator",
"src/tools/linkchecker",
Expand Down
2 changes: 1 addition & 1 deletion src/tools/clippy/.github/workflows/clippy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
echo "LD_LIBRARY_PATH=${SYSROOT}/lib${LD_LIBRARY_PATH+:${LD_LIBRARY_PATH}}" >> $GITHUB_ENV

- name: Build
run: cargo build --features deny-warnings,internal
run: cargo build --tests --features deny-warnings,internal

- name: Test
run: cargo test --features deny-warnings,internal
Expand Down
2 changes: 1 addition & 1 deletion src/tools/clippy/.github/workflows/clippy_bors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
echo "$SYSROOT/bin" >> $GITHUB_PATH

- name: Build
run: cargo build --features deny-warnings,internal
run: cargo build --tests --features deny-warnings,internal

- name: Test
if: runner.os == 'Linux'
Expand Down
Loading