Use actions/deploy-pages to deploy the website #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ehuss
force-pushed
the
deploy-gh-pages
branch
2 times, most recently
from
1234baf to
076a8a4
Compare
|
Yes, I think that the last time we did this we had to switch the source to GitHub Actions in the repository settings. |
marcoieni
reviewed
Jun 6, 2025
.github/workflows/deploy.yml
Outdated
| path: ./book | ||
|
|
||
| deploy: | ||
| if: github.ref == 'refs/heads/master' |
There was a problem hiding this comment.
please change all the conditions to if: github.ref == 'refs/heads/master' && github.repository_owner == 'rust-lang' so that this job doesn't run in forks
9 tasks
This switches from rust-lang/simpleinfra/github-actions/static-websites to using GitHub's native actions/deploy-pages to deploy the site. The deploy part of static-websites doesn't seem to be getting updated, and by the discussion at https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Remove.20static-websites.20GitHub.20Action/with/474632056 I get the impression that the infra team would prefer to retire it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from rust-lang/simpleinfra/github-actions/static-websites to using GitHub's native actions/deploy-pages to deploy the site. The deploy part of static-websites doesn't seem to be getting updated, and by the discussion at https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Remove.20static-websites.20GitHub.20Action/with/474632056 I get the impression that the infra team would prefer to retire it.
r? marcoieni
Since you seem to have some context here.
I think this will need settings changes before merging. IIUC, static-websites was deploying to a branch, but deploy-pages changes the source. In
Settings > Pages > Build and Deployment > SourceI think the source needs to be changed to "GitHub Actions", though check my understanding since I am uncertain.