Rollup of 5 pull requests #5883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add an easy-to-see note at the top of `CONTRIBUTING.md` that points new contributors to the Basics docs * Add a note about compiler errors as a result of internals changes that break Clippy
Add the new lint `same_item_push` changelog: Add the new lint `same_item_push` Fixed rust-lang#4078. As I said in rust-lang#4078 (comment), I referrerd to rust-lang#4647.
…to,flip1995 New lint against `Self` as an arbitrary self type Fixes rust-lang#5861 changelog: * [`needless_arbitrary_self_type`] [rust-lang#5869](rust-lang#5869)
…rialize, r=flip1995 enable #[allow(clippy::unsafe_derive_deserialize)] Before this change this lint could not be allowed as the code we are checking is automatically generated. changelog: Enable using the `allow` attribute on top of an ADT linted by [`unsafe_derive_deserialize`]. Fixes: rust-lang#5789
…flip1995 Lint .min(x).max(y) with x < y Fixes rust-lang#5854 changelog: Also lint `ord.min(a).max(b)`, where `a < b` in [`min_max`] lint
Make the docs clearer for new contributors It confused me before, so I made it extra obvious that you need to run a script to set up your toolchain before you can build Clippy. I also added a note so that new contributors aren't confused when Clippy doesn't build as a result of a change in rustc's internals. changelog: make `CONTRIBUTING.md` clearer for new contributors
|
@bors r+ p=5 |
|
📌 Commit 7f6897c has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
same_item_push#5825 (Add the new lintsame_item_push)Selfas an arbitrary self type #5869 (New lint againstSelfas an arbitrary self type)Failed merges:
r? @ghost
changelog: rollup