Skip to content

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Nov 7, 2025

Closes #16042
Closes #16044

changelog: [single_range_in_vec_init] fix FP for explicit Range

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@profetia
Copy link
Contributor Author

profetia commented Nov 7, 2025

Also closes #16044

@ada4a
Copy link
Contributor

ada4a commented Nov 7, 2025

imo it would be better to preserve what the user wrote, i.e. if the original expression was a range, then we should use that in the suggestion as well

@Jarcho
Copy link
Contributor

Jarcho commented Nov 7, 2025

We shouldn't be linting the explicit constructor. The lint is meant to catch vec![1..4] being used when vec![1, 2, 3] was intended.

@rustbot

This comment has been minimized.

@profetia
Copy link
Contributor Author

profetia commented Nov 7, 2025

You are right. It should be considered as a FP instead

@profetia profetia changed the title Fix single_range_in_vec_init wrongly showed field name when using Range Fix single_range_in_vec_init FP for explicit Range Nov 7, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 10, 2025
@samueltardieu
Copy link
Member

samueltardieu commented Nov 10, 2025

Also, it looks like the @no-rustfix can be removed.

@profetia
Copy link
Contributor Author

@samueltardieu Updated. Thank you!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Nov 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

5 participants