-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix single_range_in_vec_init FP for explicit Range
#16043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
rustbot has assigned @samueltardieu. Use |
|
Also closes #16044 |
|
imo it would be better to preserve what the user wrote, i.e. if the original expression was a range, then we should use that in the suggestion as well |
|
We shouldn't be linting the explicit constructor. The lint is meant to catch |
This comment has been minimized.
This comment has been minimized.
|
You are right. It should be considered as a FP instead |
single_range_in_vec_init wrongly showed field name when using Rangesingle_range_in_vec_init FP for explicit Range
|
Also, it looks like the |
|
@samueltardieu Updated. Thank you! |
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Closes #16042
Closes #16044
changelog: [
single_range_in_vec_init] fix FP for explicitRange