Fix compilation failures caused by changes in the compiler #1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the compiler change I was referring to. |
|
There's already a rustup PR #1505 I think both PRs have the same solutions, so I'm going to close this one. If you can detect any issues in the other PR, please point them out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost ready to be merged. I need help with the lifetime.rs changes. Based on the changes in the compiler, an elided lifetime should be the same as the previous
Nonecase, but the lifetime tests are still failing. I have no idea why. Everything else passes and compiles.Note: I also removed the feature
repeat_strsince it's now stable by default.cc @Manishearth
Fixes #1509