Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend needless_collect #14361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

extend needless_collect #14361

wants to merge 1 commit into from

Conversation

lengyijun
Copy link
Contributor

changelog: [needless_collect]: extend needless_collect to lint more cases

Fix #14350

@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 6, 2025
@lengyijun lengyijun force-pushed the extend_needless_collect branch 2 times, most recently from eb133b0 to 5edcbbb Compare March 6, 2025 12:10
y21
y21 reviewed Mar 8, 2025
View reviewed changes
@lengyijun lengyijun force-pushed the extend_needless_collect branch from 6a16dae to 2d3a3df Compare March 9, 2025 00:12
@lengyijun
Copy link
Contributor Author

@y21 Ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 left review comments

Assignees

@y21 y21

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extend needless_collect
3 participants
@lengyijun @rustbot @y21