Rename inconsistent_struct_constructor configuration; don't suggest deprecated configurations
#14280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
smoelius
force-pushed
the
lint-to-check
branch
2 times, most recently
from
0c3200f to
79e5125
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I can reproduce the failure locally. I will look into fixing it. EDIT: 🤞 EDIT 2: 😀 |
|
@y21 I just rebased this again. Do you think you could please try merging again? |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Sorry, my rebase left off one commit. Could you please try merging one more time? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
inconsistent_struct_constructor's configuration fromlint-inconsistent-struct-field-initializerstocheck-inconsistent-struct-field-initializers. (I should have suggestedcheck-...in #13737.)cyclomatic-complexity-threshold, for example.)r? @y21
changelog: Rename
lint-inconsistent-struct-field-initializerstocheck-inconsistent-struct-field-initializerschangelog: No longer suggest deprecated configurations