Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wildcard_imports: lint on pub use if asked to #14182

Merged
merged 1 commit into from
Mar 25, 2025
Merged

wildcard_imports: lint on pub use if asked to #14182

merged 1 commit into from
Mar 25, 2025

Conversation

samueltardieu
Copy link
Contributor

warn_on_all_wildcard_imports should warn on all wildcard imports, including the reexported ones.

Fix #13660

changelog: [warn_on_all_wildcard_imports]: when asked to warn on all wildcard imports, include the reexported ones

@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 9, 2025
@samueltardieu
Copy link
Contributor Author

@y21 Should I reassign?

@samueltardieu samueltardieu changed the title wildcard_imports: lint on pub use if asked too wildcard_imports: lint on pub use if asked to Feb 26, 2025
y21
y21 approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small nit: can you also update the documentation for the config option to mention this new behavior?

@y21 y21 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 19, 2025
@samueltardieu
wildcard_imports: lint on pub use if asked to
809c931 
`warn_on_all_wildcard_imports` should warn on all wildcard imports,
including the reexported ones.
@y21 y21 added this pull request to the merge queue Mar 25, 2025
Merged via the queue into rust-lang:master with commit 9c6cb51 Mar 25, 2025
11 checks passed
@samueltardieu samueltardieu deleted the push-qkuunsumnxxm branch March 25, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 approved these changes

Assignees

@y21 y21

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wildcard_imports is ignored in pub uses
3 participants
@samueltardieu @rustbot @y21