fix suggestion for assignments have enclosing parentheses under needless_late_init
#14169
+34
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lapla-cogito
commented
Feb 7, 2025
|
|
||
| fn issue9895() { | ||
| let r; | ||
| (r = 5); |
There was a problem hiding this comment.
These patterns can also be ignored, but I thought it wouldn't be a problem to remove the enclosing parentheses here, since an assignment returns the unit value.
lapla-cogito
force-pushed
the
issue_9895
branch
from
ce9ae6f to
ff1b0c5
Compare
|
Rebased to address the recent changes in error annotation. |
y21
reviewed
Feb 22, 2025
lapla-cogito
force-pushed
the
issue_9895
branch
3 times, most recently
from
c618387 to
62c41e2
Compare
lapla-cogito
force-pushed
the
issue_9895
branch
from
62c41e2 to
af40c23
Compare
|
@y21 Could you take a look at this when you have some time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9895
changelog: [
needless_late_init]: correct suggestion when assignments have enclosing parentheses