Correctly handle string indices in literal_string_with_formatting_arg
#13841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to set assignee to
|
rustbot
added
the
S-waiting-on-review
|
r? |
|
Ah funny, I thought it would reroll. Oh well. r? clippy |
Centri3
reviewed
Dec 16, 2024
| current = ¤t[error.span.end + 1..]; | ||
| let mut pos = 0; | ||
| // We find the closest char to where the error location ends. | ||
| for (char_pos, _) in current.char_indices() { |
There was a problem hiding this comment.
My first thought was to use ceil_char_boundary, also is_char_boundary exists. Any reason to not use them?
There was a problem hiding this comment.
I didn't know they existed. :o
Thanks!
GuillaumeGomez
force-pushed
the
fix-literal_string_with_formatting_arg-str-indices
branch
from
5f27365 to
ad695da
Compare
flip1995
approved these changes
Dec 16, 2024
|
Welcome to the club! \o/ |
|
Once again i avoided ?r, nice. Btw, this one was found while i run clippy over r-a, so expect more reports until rust sync. |
GuillaumeGomez
deleted the
fix-literal_string_with_formatting_arg-str-indices
branch
|
It's very welcome, thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13838.
r? @klensy
changelog: Correctly handle string indices in
literal_string_with_formatting_arg