Run rustfmt #1259
Run rustfmt #1259
Conversation
|
And of course now #1246 is calling and there will be horrible merge conflicts I'm sure \o/ |
|
No conflict whatsoever, where is the fun git? |
| span_lint_and_then(cx, USELESS_ATTRIBUTE, attr.span, | ||
| span_lint_and_then(cx, | ||
| USELESS_ATTRIBUTE, | ||
| attr.span, | ||
| "useless lint attribute", | ||
| |db| { | ||
| sugg.insert(1, '!'); |
There was a problem hiding this comment.
I actually like what rustfmt did with our closures. They look like this closure now.
There was a problem hiding this comment.
The thing is it did not format them all the same. Sometimes pushing the content to the left like here, sometimes pushing it to the right 😕
There was a problem hiding this comment.
try closure_block_indent_threshold = -1 or closure_block_indent_threshold = 99
| "useless lint attribute", | ||
| |db| { | ||
| sugg.insert(1, '!'); | ||
| db.span_suggestion(attr.span, "if you just forgot a `!`, use", sugg); | ||
| }); | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
set match_block_trailing_comma = true
There was a problem hiding this comment.
I don't really have a strong opinion on that one. The default looks fine.
There was a problem hiding this comment.
I have a strong opinion :P I really like the fact that you can distinguish a match arm block closing bracket from other closing brackets, but I can do my own PR when I get around to it.
|
I reran rustfmt, there was a really degenerate case in one of our tests, but even I can't figure out how to format that properly, so I just slapped on a |
|
@oli-obk You realize this only runs rustfmt on |
|
whoops fixing I was wondering why I got so few hits |
😄 |
So I was going to integrate coverage tests in Travis, but @Manishearth was to fast.
So I though “Hey, what other tool could I fight against? Oh I know, it's been a long time since we haven't run
rustfmt!”.rustfmtdecides what to do withmatcharms and another one for all our|db| {}lambdas.