add completions for clippy lint in attributes #6109
Conversation
|
Reqwest seems like quite a big dependency for just simple get requests, I think attohttpc with the |
bnjjj
force-pushed
the
master
branch
2 times, most recently
from
2173416 to
d6cd46d
Compare
|
Maybe |
|
@lnicola Yes indeed it could be a good idea. I add this in my todo list. And I will make a new PR with these changes if it's good for you to iterate ? |
|
CC rust-lang/rust-clippy#5385, see my last comment. It's already available, but doesn't work for us at the moment. I think we could live with the codegen approach for a while. |
|
Let me clarify one thing, I don't fetch this url http://rust-lang.github.io/rust-clippy/master/index.html as you mentioned in the clippy issue but the json located here http://rust-lang.github.io/rust-clippy/master/lints.json which is far better than scrapping an html page :p |
|
Hm, I'd rather not add any networing, even to the build |
We're already doing the same sort of thing for rustc features, aren't we? |
|
We are relying on external process for that, this is fine. I'd rather avoid adding more crates to our crate graph, unless we absolutely need them. HTTP crate feels like something we absolutely don't need :D |
|
Maybe I can use curl to download the json as you do a git clone to codegen features |
|
updated with network crate deleted |
|
up @matklad if you can give me your thoughts :) |
|
See also rust-lang/rust#77671. |
|
@matklad updated with your suggests :) thanks for your review |
|
lgmt with rebase and one last nit fixed bors d+ |
|
✌️ bnjjj can now approve this pull request. To approve and merge a pull request, simply reply with |
bnjjj
force-pushed
the
master
branch
2 times, most recently
from
2e764b3 to
5ba8f75
Compare
Signed-off-by: Benjamin Coenen <[email protected]>
|
bors r+ |
No description provided.