internal: Merge smol_str into rust-analyzer
#20988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement From<&str>
Implement PartialEq<SmolStr> and From<String>
I don't understand the sentence that starts with *Runs of `\n` and space symbols*... What do you mean by that?
Fix some stuff in the readme
Clarify docs
rustfmt with stable.
Fix typo in Cargo.toml.
Fix test compilation without serde feature.
Since there is a `len` method, clippy suggests having an `is_empty` method as well.
clippy: Add (and test) is_empty method.
rustbot
added
the
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
added
has-merge-commits
S-waiting-on-author
Veykril
force-pushed
the
push-rutmxykksupu
branch
from
d876dee to
c55ff7b
Compare
Veykril
force-pushed
the
push-rutmxykksupu
branch
from
c55ff7b to
f2a0c2c
Compare
Member
Author
|
Will remove / update ci workflows after all is merged |
Veykril
force-pushed
the
push-rutmxykksupu
branch
3 times, most recently
from
63ff757 to
1cbf685
Compare
Veykril
force-pushed
the
push-rutmxykksupu
branch
from
1cbf685 to
832fd1a
Compare
Veykril
force-pushed
the
push-rutmxykksupu
branch
from
832fd1a to
64b00e7
Compare
rustbot
removed
the
S-waiting-on-review
lnicola
changed the title
smol_str into rust-analyzersmol_str into rust-analyzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
25 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in https://github.com/rust-analyzer/smol_str, moving maintenance into the main repo.