Fix negative integer literals in const generics in declarative macro context #20745
+55
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Oblarg
force-pushed
the
fix-negative-int-literals-in-macro-by-example
branch
2 times, most recently
from
d21863e to
be8147e
Compare
…ral const generic params
Oblarg
force-pushed
the
fix-negative-int-literals-in-macro-by-example
branch
from
be8147e to
03aabd4
Compare
There was a problem hiding this comment.
Looks good in overall. We should wrap the expressions with DelimiterKind::Invisible rather than parentheses but we don't have them now #16168, so this would be the best without much hassle.
But as the current parentheses expansion behavior is a bit hacky and temporary, I think the test should be located in hover or other similar location instead of this mbe crate.
Oblarg
force-pushed
the
fix-negative-int-literals-in-macro-by-example
branch
2 times, most recently
from
8501e78 to
c1e26f8
Compare
Oblarg
force-pushed
the
fix-negative-int-literals-in-macro-by-example
branch
from
c1e26f8 to
b8852fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20750
These currently are broken due to incorrect parentheses-wrapping behavior in the transcriber
disclaimer: again, this was AI-assisted; but it seems to be local and the AI seems to have found the correct solve