Fix to implements in-place stdx::replace #20706
Merged
+41
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
A4-Tacks
force-pushed
the
stdx-replace-inplace
branch
from
c781a5c to
314ab76
Compare
| while let Some(i) = buf[..end].rfind(from) { | ||
| buf.replace_range(i..i + from_len, to); | ||
| end = i; | ||
| } |
There was a problem hiding this comment.
The implementation looks great. But seems that we don't have any test for this function so far. Could we have a simple test for this?
A4-Tacks
force-pushed
the
stdx-replace-inplace
branch
from
314ab76 to
29de96c
Compare
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.