Skip to content

Conversation

ShoyuVanilla
Copy link
Member

Fixes #20651

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2025
@ShoyuVanilla ShoyuVanilla changed the title fix: Make flycheck clearing dependancy-aware fix: Make flycheck clearing dependency-aware Sep 18, 2025
@ShoyuVanilla ShoyuVanilla force-pushed the accurate-flycheck branch 2 times, most recently from 565645b to 9abf32d Compare September 18, 2025 18:37
Copy link
Contributor

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How large are PackageIds? Do they need to be wrapped in an Arc?

@ShoyuVanilla
Copy link
Member Author

ShoyuVanilla commented Sep 19, 2025

How large are PackageIds? Do they need to be wrapped in an Arc?

TBH, I don't think it's that large to be necessarily wrapped in Arcs in general, but might be arbitrily large in rare cases if nested in a long filesystem path, as it looks like "file:///absolute/path/to/my-package#0.1.0".
I saw some places in our codebase that wrapping PackageId in Arc, so just followed it. If you thing Arc is redundant, I'm not opposing to removing them.

@davidbarsky
Copy link
Contributor

How large are PackageIds? Do they need to be wrapped in an Arc?

TBH, I don't think it's that large to be necessarily wrapped in Arcs in general, but might be arbitrily large in rare cases if nested in a long filesystem path, as it looks like "file:///absolute/path/to/my-package#0.1.0". I saw some places in our codebase that wrapping PackageId in Arc, so just followed it. If you thing Arc is redundant, I'm not opposing to removing them.

Ah, gotcha. Yeah, I guess they’re fine as-is, I just wasn’t sure if they were strings or u32s from the code review alone. This looks good to me!

@davidbarsky davidbarsky added this pull request to the merge queue Sep 20, 2025
Merged via the queue into rust-lang:master with commit a196eba Sep 20, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 20, 2025
@ShoyuVanilla ShoyuVanilla deleted the accurate-flycheck branch September 20, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After saving a binary target related file, rust-analyzer reports 0 errors even though some errors remain
3 participants