fix: Make flycheck clearing dependency-aware

[ShoyuVanilla]

Fixes #20651

[davidbarsky]

How large are PackageIds? Do they need to be wrapped in an Arc?

[ShoyuVanilla]

How large are PackageIds? Do they need to be wrapped in an Arc?

TBH, I don't think it's that large to be necessarily wrapped in Arcs in general, but might be arbitrily large in rare cases if nested in a long filesystem path, as it looks like "file:///absolute/path/to/my-package#0.1.0".
I saw some places in our codebase that wrapping PackageId in Arc, so just followed it. If you thing Arc is redundant, I'm not opposing to removing them.

[davidbarsky]

How large are PackageIds? Do they need to be wrapped in an Arc?

TBH, I don't think it's that large to be necessarily wrapped in Arcs in general, but might be arbitrily large in rare cases if nested in a long filesystem path, as it looks like "file:///absolute/path/to/my-package#0.1.0". I saw some places in our codebase that wrapping PackageId in Arc, so just followed it. If you thing Arc is redundant, I'm not opposing to removing them.

Ah, gotcha. Yeah, I guess they’re fine as-is, I just wasn’t sure if they were strings or u32s from the code review alone. This looks good to me!