Port closure inference from rustc #19536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Nit: do we want those |
rust-cloud-vms
bot
force-pushed
the
closure-infer
branch
2 times, most recently
from
47e7183 to
48cfc79
Compare
|
Squashed and removed all the tracing bits. |
Veykril
approved these changes
Apr 7, 2025
flodiebold
approved these changes
Apr 7, 2025
flodiebold
approved these changes
Apr 7, 2025
rust-cloud-vms
bot
force-pushed
the
closure-infer
branch
from
48cfc79 to
bc3e9d9
Compare
|
Reviews addressed |
davidbarsky
reviewed
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need this with chalk (though, I do wonder if this sidesteps rust-lang/chalk#688), but this is required for the next-solver integration.
I haven't gone through this and done any "cleanups", this is just ripped straight from my next-solver branch.I think this is ready for review.