Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to-announce label to finalized FCPs #289

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Add to-announce label to finalized FCPs #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/github/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ pub enum Label {
FCP,
Postponed,
Closed,
ToAnnounce,
DispositionMerge,
DispositionClose,
DispositionPostpone,
Expand All @@ -26,6 +27,7 @@ impl Label {
FCP => "final-comment-period",
Postponed => "postponed",
Closed => "closed",
ToAnnounce => "to-announce",
DispositionMerge => "disposition-merge",
DispositionClose => "disposition-close",
DispositionPostpone => "disposition-postpone",
Expand Down
10 changes: 9 additions & 1 deletion src/github/nag.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,15 @@ fn evaluate_ffcps() -> DashResult<()> {
let label_res = issue.add_label(Label::FFCP);
issue.remove_label(Label::FCP);
let added_label = match label_res {
Ok(_) => true,
Ok(_) => {
if let Err(why) = issue.add_label(Label::ToAnnounce) {
warn!(
"Unable to add to-announce label to {}#{}: {:?}",
&issue.repository, issue.number, why
);
}
true
}
Err(why) => {
warn!(
"Unable to add Finished-FCP label to {}#{}: {:?}",
Expand Down