Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: orphan rule rationale. #1755

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add: orphan rule rationale. #1755

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
137860d
Add: orphan rule rationale.
TmSalviano Mar 11, 2025
009ebdd
Fix: grammar error . Fix: improved semantics
TmSalviano Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/items/implementations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,15 @@ be instantiable with the same set of types for the input type parameters. -->
r[items.impl.trait.orphan-rule]
#### Orphan rules

r[items.impl.trait.orphan-rule.rationale]
The orphan rule helps ensure that other people's code can't break your code, and vice versa.
If an external crate implements an external trait for an external type, and your crate also
implements the same trait for the same type, the compiler wouldn't know which implementation
to use.\
The orphan rule prevents this by requiring that either the trait or some type in the
implementation is local to your crate, ensuring only one crate defines the implementation and
thereby maintaining coherence.
Comment on lines +183 to +184
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally put a “that” here:

Suggested change
implementation is local to your crate, ensuring only one crate defines the implementation and
thereby maintaining coherence.
implementation is local to your crate, ensuring that only one crate defines the implementation
and thereby maintaining coherence.

Comment on lines +177 to +184
Copy link
Contributor

@traviscross traviscross Mar 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we'll want to move this into a note section, but it's generally going in the right direction. The one caveat I'd add is that the problem being prevented here isn't really about the compiler not knowing what to pick. The compiler knows what to do about that. It'd throw an ambiguity error. But what that means is that adding an impl for your own types or of your own traits would be breaking (in many more situations). So it's mostly about saving space for such authors, and that's the real rationale. Of course, whenever you talk about removing the rule, you do find out all the ways that we are leaning on the rule more technically, and those reasons are a bit more subtle. E.g.:


r[items.impl.trait.orphan-rule.general]
Given `impl<P1..=Pn> Trait<T1..=Tn> for T0`, an `impl` is valid only if at
least one of the following is true:
Expand Down