Update procedural-macros.md adding context for use of `extern crate p… #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roc_macro` Use of `extern crate` is generally stopped and not recommended [source](https://github.com/rust-lang/edition-guide/blob/master/src/rust-2018/path-changes.md#an-exception). Its use here was confusing for me. Based on the config provided here for the `Cargo.toml` file, use of `extern crate proc_macro;` in following examples is not required. The snippets were last updated 6 years ago. I would personally remove use of `extern crate` crate from following examples and add one with it to show how it can be done when using separate build system.
|
We discussed this in the rustdocs call. We appreciate the PR; thanks @mav3ri3k for proposing it. However, we're going to close it as it goes a bit too far in discussing details of Cargo that aren't really appropriate for the Reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of
extern crateis generally stopped and not recommended source. Its use here was confusing for me. Based on the config provided here for theCargo.tomlfile, use ofextern crate proc_macro;in following examples is not required.The snippets were last updated 6 years ago. I would personally remove use of
extern cratecrate from following examples and add one with it to show how it can be done when using separate build system which would likely be niche case.