Skip to content

Conversation

@folkertdev
Copy link
Contributor

@folkertdev folkertdev commented Nov 10, 2025

Adds the first dedicated avx512 shim, so that requires some setup.

The ternary logic functions are used in avx512 crc32 implementations, I'm specifically implementing one in zlib-rs right now.

@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2025

Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two.
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Nov 10, 2025
@RalfJung
Copy link
Member

RalfJung commented Nov 11, 2025 via email

@RalfJung
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Nov 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@RalfJung
Copy link
Member

This looks great, thanks! Please squash the commits using ./miri squash. Then write @rustbot ready after you force-pushed the squashed PR.

@rustbot author

@folkertdev
Copy link
Contributor Author

Is CI flaky here?

E: Failed to fetch http://ports.ubuntu.com/ubuntu-ports/dists/noble-security/main/binary-armhf/Packages.xz  File has unexpected size (442940 != 443108). Mirror sync in progress? [IP: 91.189.91.102 80]
   Hashes of expected file:
    - Filesize:443108 [weak]
    - SHA256:94e16562de548af81cd7fe9f2c811beac145a8578215679cf9e859980d78c1db
    - SHA1:0754fc5a9770987305b40d119f88cfaf4530246b [weak]
    - MD5Sum:b0e683c5e432662b34d2c45edc9822ca [weak]
   Release file created at: Tue, 11 Nov 2025 15:57:34 +0000
E: Some index files failed to download. They have been ignored, or old ones used instead.
Error: Process completed with exit code 100.

@RalfJung
Copy link
Member

Yeah the Ubuntu ports mirrors are pretty bad, we already disabled most ports CI -- armv7 has been better so far but also sometimes fails. :/

@RalfJung RalfJung enabled auto-merge November 11, 2025 17:53
@RalfJung RalfJung added this pull request to the merge queue Nov 11, 2025
Merged via the queue into rust-lang:master with commit 667796b Nov 11, 2025
13 checks passed
@rustbot rustbot removed the S-waiting-on-author Status: Waiting for the PR author to address review comments label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants