-
Notifications
You must be signed in to change notification settings - Fork 406
add shim for avx512 ternarylogic functions #4678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
|
Thanks!
I meant to add more tests, not replace the existing ones. But this is fine too as long as all 3 are covered. The masking seems to be implemented in stdtach so we don't really need to test that here.
Did you confirm these on real HW?
|
|
@rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
|
This looks great, thanks! Please squash the commits using @rustbot author |
11ee0c4 to
7011d8e
Compare
|
Is CI flaky here? |
|
Yeah the Ubuntu ports mirrors are pretty bad, we already disabled most ports CI -- armv7 has been better so far but also sometimes fails. :/ |
7011d8e to
24a8e24
Compare
Adds the first dedicated avx512 shim, so that requires some setup.
The ternary logic functions are used in avx512 crc32 implementations, I'm specifically implementing one in zlib-rs right now.