Copy compiler/rustc_lexer/src/unescape source code #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urgau
reviewed
Apr 3, 2025
| [package] | ||
| name = "literal-escaper" | ||
| version = "0.0.1" | ||
| edition = "2021" |
There was a problem hiding this comment.
Suggested change
| edition = "2021" | |
| edition = "2021" | |
| description = "Provides code to unescape string literals" | |
| license = "Apache-2.0 OR MIT" | |
| repository = "https://github.com/rust-lang/literal-escaper" |
we should also provide the licenses files in this repo as well
Urgau
reviewed
Apr 3, 2025
GuillaumeGomez
force-pushed
the
first-commit
branch
2 times, most recently
from
0f417ea to
de22028
Compare
GuillaumeGomez
force-pushed
the
first-commit
branch
from
de22028 to
cc19151
Compare
Urgau
approved these changes
Apr 3, 2025
|
Alright, this is a an good enough state to be merged as is. Next step will be to add to add the licenses files, the code of conduct, a changelog and a README.md before we can think of releasing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that rust-lang/team#1707 got merged, time to copy code.
Once merged, can someone do a crates.io release please?
r? @Urgau