Skip to content

chore: minor cleanup mode_t usage #4405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Apr 14, 2025

crate::mode_t is almost never needed because it is part of prelude. Moreover, in many cases mode_t was already used without the prefix - thus confusing if they are different or not. Keeping it the same helps readability.

@rustbot label +stable-nominated

@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2025

Some changes occurred in OpenBSD module

cc @semarie

Some changes occurred in OpenBSD module

cc @semarie

Some changes occurred in the Android module

cc @maurer

Some changes occurred in solarish module

cc @jclulow, @pfmooney

@nyurik nyurik force-pushed the cleaner-mode_t branch 7 times, most recently from 3d2493f to ce240f5 Compare April 14, 2025 03:02
`crate::mode_t` is almost never needed because it is part of prelude.  Moreover, in many cases `mode_t` was already used without the prefix - thus confusing if they are different or not. Keeping it the same helps readability.
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 added this pull request to the merge queue Apr 15, 2025
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Apr 15, 2025
Merged via the queue into rust-lang:main with commit 6d20f42 Apr 15, 2025
46 of 47 checks passed
@nyurik nyurik deleted the cleaner-mode_t branch April 15, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants