Skip to content

Update pidfd constants and types (Linux 6.9-6.15) #4402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

rusty-snake
Copy link
Contributor

Description

Add pidfd constants for thread targeting pidfds.

Sources

https://github.com/torvalds/linux/blob/3bde70a2c82712f05c7220b8b94fc2cbdf7fbfe0/include/uapi/linux/pidfd.h#L10-L21

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@rustbot
Copy link
Collaborator

rustbot commented Apr 12, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-gnu O-linux O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 12, 2025
@rusty-snake
Copy link
Contributor Author

(rebase)

@rusty-snake
Copy link
Contributor Author

No idea why CI is failing.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small request but LGTM as long as CI passes. I'm not sure why the Windows job failed, those have been a bit spurious recently.

Could you also squash please?

@rusty-snake rusty-snake changed the title Add pidfd constants for thread targeting pidfds Update pidfd constants and types (Linux 6.9-6.15) Apr 16, 2025
@tgross35
Copy link
Contributor

Actually, why is this GNU only? Shouldn't it be available for musl and other libcs since it is uapi?

@rusty-snake
Copy link
Contributor Author

Yeah, glibc does nothing special. It has a some userspace helper functions like pidfd_getpid and APIs like pidfd_spawn (posix_spawn with pidfd support).
I simply looked for PIDFD_NONBLOCK and added the rest next to it.

Will move it to linux_like.

@rusty-snake
Copy link
Contributor Author

Moved to linux_like/linux/mod.rs

@tgross35 tgross35 added this pull request to the merge queue Apr 25, 2025
Merged via the queue into rust-lang:main with commit 1b5abd7 Apr 25, 2025
50 checks passed
@rusty-snake rusty-snake deleted the pidfd-threaded branch April 25, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-arm O-gnu O-linux O-mips O-musl O-unix O-x86 S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants