Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libc to 0.2.171 to use sigaction for AIX #109

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

xingxue-ibm
Copy link
Contributor

Change to use sa_sigaction instead of sa_union.__su_sigaction, now that the libc crate 0.2.171 implementation for AIX defines sa_sigaction as a direct member of struct sigaction, aligning it with implementations on other similar platforms. (rust-lang/libc#4250).

@xingxue-ibm xingxue-ibm changed the title Bump libc to 0.2.171 to fix sigaction Bump libc to 0.2.171 to use sigaction for AIX Mar 14, 2025
@daltenty
Copy link

daltenty commented Apr 1, 2025

Gentle ping, you can't build jobserver right now on AIX:

error[E0609]: no field `sa_union` on type `sigaction`
   --> /home/buildusr/.cargo/registry/src/index.crates.io-d11c229612889eed/jobserver-0.1.32/src/unix.rs:399:17
    |
399 |             new.sa_union.__su_sigaction = sigusr1_handler;
    |                 ^^^^^^^^ unknown field
    |
    = note: available fields are: `sa_sigaction`, `sa_mask`, `sa_flags`

@daltenty
Copy link

daltenty commented Apr 1, 2025

LGTM from the AIX perspective

Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks reasonable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might also want to bump libc to 0.2.171 in Cargo.toml, so people will not accidentally get older versions and fail to compile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Changed as suggested, thanks!

@weihanglo weihanglo merged commit 665135d into rust-lang:main Apr 1, 2025
15 checks passed
@weihanglo
Copy link
Member

Thanks. Ping me again if I forget to publish a new version today or tomorrow

@weihanglo weihanglo mentioned this pull request Apr 1, 2025
@weihanglo
Copy link
Member

jobserver@0.1.33 is out.

@xingxue-ibm
Copy link
Contributor Author

Thank you, @weihanglo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants