This repository was archived by the owner on Jan 15, 2026. It is now read-only.
docs: Replace deprecated --preserve-merges with --rebase-merges#218
Open
choznerol wants to merge 1 commit intorust-lang:masterfrom
Open
docs: Replace deprecated --preserve-merges with --rebase-merges#218choznerol wants to merge 1 commit intorust-lang:masterfrom
--preserve-merges with --rebase-merges#218choznerol wants to merge 1 commit intorust-lang:masterfrom
Conversation
527c8a5 to
d938f23
Compare
|
For what it's worth, the default branch name has been changed from master to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #217
I'm not 100% sure about recommending
--rebase-merges, or if the default behavior (dropping merge commits) would be just fine.We may want
git rebase upstream/master --rebase-mergesbecause there is probably a reason we recommended--preserve-mergesin the first place. According to the documentation,--rebase-mergesis most similar to--preserve-merges:On the other hand, if we're unclear why we recommended
--preserve-mergesin the first place (considering #217 might have been an issue since 2021), maybe the simplergit rebase upstream/masteris just better.Disclaimer: I never knew about
--preserve-mergesor--rebase-mergesbefore #217.