Add OrPending future that wraps an optional future #2968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a different behavior for `Option<F>` than the existing Option future: instead of resolving to `Option<F::Output>` it resolves to `F::Output` if the future is present; otherwise it does not resolve. This can be useful for code paths that `select!` on multiple futures where one of the futures is optional. Using this wrapper allows sharing code paths since if the optional future is not present, that `select!` arm simply won't resolve.
rustbot
added
A-future
|
We've been using something like this in libsignal for a while and it's been generally useful, so I figured it might be useful more broadly as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a different behavior for
Option<F>than the existingfutures_util::future::Optionfuture: instead of resolving toOption<F::Output>it resolves toF::Outputif the future is present; otherwise it does not resolve.This can be useful for code paths that
select!on multiple futures where one of the futures is optional. Using this wrapper allows sharing code paths since if the optional future is not present, thatselect!arm simply won't resolve.